fix(tui): remove dead PlaceholderScreen and fix gateway wizard UX#597
Merged
fix(tui): remove dead PlaceholderScreen and fix gateway wizard UX#597
Conversation
aidandaly24
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
This was referenced Mar 23, 2026
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
tejaskash
previously approved these changes
Mar 23, 2026
- Remove unreachable PlaceholderScreen route and component (dead code)
- Add exitEnabled={false} to gateway wizard Screen to prevent
accidental Escape exit mid-flow
- Show friendly authorizer name in confirm review instead of raw enum
- Update output key comment to document hash suffix pattern
aidandaly24
force-pushed
the
fix/cleanup
branch
from
3e80f41 to
c439cbf
Compare
aidandaly24
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
aidandaly24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small cleanup PR that removes dead code and fixes a minor display issue in the gateway confirmation screen:
PlaceholderScreencomponent and its import/route/re-exportelsebranch and deadCommandMetatype import inApp.tsxCUSTOM_JWT)Related Issue
Extracted from #596
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.