Enable DualStack ECR Image URI #4612
Merged
+652
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheanLim
reviewed
May 2, 2025
TheanLim
reviewed
May 2, 2025
ShelbyZ
force-pushed
the
dualstack-uri
branch
2 times, most recently
from
d5b7934 to
5ee8d10
Compare
ShelbyZ
changed the title
ShelbyZ
changed the title
amogh09
reviewed
May 21, 2025
ShelbyZ
force-pushed
the
dualstack-uri
branch
2 times, most recently
from
a88b856 to
d7d0416
Compare
amogh09
previously approved these changes
May 21, 2025
TheanLim
reviewed
May 22, 2025
TheanLim
previously approved these changes
May 22, 2025
- Add plumbing to check IPv6-only (bool) and set DualStack ECR when needed - updated testing and introduced new testing for endpoint overrides/IPCompatibility - Removed prefix matching (ProxyEndpoint and Image URI) that would prevent default ECR endpoint with DualStack Image URI (and reverse) - Update aws-sdk-go-v2 ECR to 1.44.0 to add DualStack support - https://github.com/aws/aws-sdk-go-v2/blob/release-2025-04-30/service/ecr/CHANGELOG.md#v1440-2025-04-30
amogh09
previously approved these changes
May 23, 2025
TheanLim
approved these changes
May 23, 2025
amogh09
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make testand local debugging, e2e testingNew tests cover the changes: yes
Description for the changelog
Enable DualStack ECR Image URI
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
N/A
Does this PR include the addition of new environment variables in the README?
N/A
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.