chore: remove aws sdk core dep #1996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajewellamz
approved these changes
Sep 30, 2025
texastony
requested changes
Sep 30, 2025
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.402.2"/> |
There was a problem hiding this comment.
Also drop DDB. Let the MPL define it.
There was a problem hiding this comment.
No we should keep DDB here, because DB-ESDK has a direct dependency on DDB.
There was a problem hiding this comment.
If the world was perfect, I would be 100% on board.
But actually, this library does NOT depend on the DDB, but on the Dafny DDB.
And the Dafny DDB is from the MPL.
But I will not die on this hill.
The hill I will die on is that this dependency resolution is wrong.
It needs to be:
<PackageReference Include="AWSSDK.DynamoDBv2" Version="[3.7.*, 4.0)" />
OR customers will continue to get confused/runtime exceptions.
|
This change is not required anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.