Skip to content

chore: remove aws sdk core dep #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: remove aws sdk core dep #1996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion DynamoDbEncryption/runtimes/net/DynamoDbEncryption.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@

<ItemGroup>
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.402.2"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also drop DDB. Let the MPL define it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we should keep DDB here, because DB-ESDK has a direct dependency on DDB.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the world was perfect, I would be 100% on board.
But actually, this library does NOT depend on the DDB, but on the Dafny DDB.
And the Dafny DDB is from the MPL.

But I will not die on this hill.
The hill I will die on is that this dependency resolution is wrong.
It needs to be:

 <PackageReference Include="AWSSDK.DynamoDBv2" Version="[3.7.*, 4.0)" />

OR customers will continue to get confused/runtime exceptions.

<PackageReference Include="AWSSDK.Core" Version="3.7.400.38"/>
<PackageReference Include="DafnyRuntime" Version="$(DafnyVersion)" />
<ProjectReference Include="../../../submodules/MaterialProviders/AwsCryptographicMaterialProviders/runtimes/net/MPL.csproj"/>
<!--
Expand Down
Loading