Issue #45: fix s3 bucket prefix construction for refs in delete command
#48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re Issue #45: fix s3 bucket prefix construction for refs in
deletecommandCurrently, the
deletecommand builds up the s3 bucket prefix without a trailing forward slash. These leads to a bug where attempting to delete a branch whose name prefixes another existing branch name will result in "not found" error.This happens because s3 will resolve the prefix two all refs whose keys share the same prefix provided to
ListObjectsV2. There's an additional bug, where if the number of objects return != 1 (or 2 for zip schemes), then thedeletecommand assumes the number of objects is 0 and returns a "not found" err.Fix this by:
ListObjectsV2calls in the library that append a trailing/. e.g. seeget_bundles_for_ref,remote_remote_refTest plan:
git checkout -b boba && git pushgit checkout -b boba-fett && git pushgit push --delete origin bobabobanow works even whenboba-fettalready exists in the remote s3 bucket.