abc@0.64-yosyshq.bcr.2#9021
Merged
Merged
Conversation
Add an opt-in flag to skip the readline dependency. Default behavior is unchanged: @readline is still linked and ABC_USE_READLINE is still set. Consumers that drive abc programmatically (and do not need the interactive line editor) can opt out by adding to .bazelrc: common --@abc//:use_readline=false This drops both the @readline build edge and the ABC_USE_READLINE define from the abc cc_library. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Member
|
Hello @UebelAndre, modules you maintain (abc) have been updated in this PR. |
Contributor
Author
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
UebelAndre
requested changes
May 27, 2026
Contributor
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
One request for you! Also, what is the error you see? Does this result in duplicate symbols somehow? Should there be a regression test with this off?
Co-authored-by: UebelAndre <github@uebelandre.com>
Contributor
Author
|
It is not an error, I don't want a GPL dependency in my program and don't need the abc CLI as I'm just using it as a library. |
…y fix Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
UebelAndre
requested changes
May 27, 2026
Co-authored-by: UebelAndre <github@uebelandre.com>
UebelAndre
added
the
presubmit-auto-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in flag to skip the readline dependency. Default behavior is unchanged:
@readlineis still linked andABC_USE_READLINEis still set. Consumers that drive abc programmatically (and do not need the interactive line editor) can opt out by adding to .bazelrc:This drops both the
@readlinebuild edge and theABC_USE_READLINEdefine from the abc cc_library.