Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not fail when setting a breakpoint in non-bazel project #5674

Closed

Conversation

blorente
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: Discovered internally.

Description of this change

If opening a non-bazel project without importing it, setting a breakpoint used to make the Bazel plugin crash.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Nov 10, 2023
@blorente blorente force-pushed the blorente/fix-breakpoint-unrelated branch from 6c08b65 to 706e9e7 Compare November 10, 2023 15:53
@mai93
Copy link
Collaborator

mai93 commented Nov 14, 2023

is this resolved by 59ddcbe?

@blorente
Copy link
Collaborator Author

Superseded by 59ddcbe

@blorente blorente closed this Nov 15, 2023
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Nov 15, 2023
@ujohnny
Copy link
Collaborator

ujohnny commented Nov 15, 2023

Actually the test looks nice, I think we anyway can merge this in.

@blorente
Copy link
Collaborator Author

@ujohnny Rebased and reopened in in #5713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants