Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittest for SkylarkDebuggingUtils to check that no exception occurs for non-bazel projects #5713

Merged

Conversation

blorente
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

This is a rebase of #5674. While the issue was fixed by 59ddcbe, the tests might be useful.

@ujohnny ujohnny changed the title fix: Do not fail when setting a breakpoint in non-bazel project Add unittest for SkylarkDebuggingUtils to check that no exception occurs for non-bazel projects Nov 22, 2023
@ujohnny ujohnny merged commit 1535596 into bazelbuild:master Nov 22, 2023
8 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants