Changes to BlazeTargetFilter regex to match more target names

[LeFrosch]

Checklist

• I have filed an issue about this change and discussed potential changes with the maintainers.
• I have received the approval from the maintainers to make this change.
• This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #4431

Description of this change

Changed the regex used by BlazeTargetFilter to include more valid target names. I used this documentation page to lookup the valid characters.

[mmendonca2]

I think this issue created a problem where a top level exclusion "-someFolder" is now excluding that folder name from the entire project, no matter if it's nested in an explicitly included target. So now "includedTarget/someFolder" is excluded as well. It's problematic when explicitly excluding top level projects from .bazelproject whose name can show up in other targets as a package folder, as it breaks their builds.

[LeFrosch]

Hi @mmendonca2, as far as I can tell the BlazeTargetFilter is only registered using a consoleFilterProvider and not used any where else. Therefore, I think it is only used for highlighting links in the console.
If this is not the case and you are sure this is related to these changes please let me know. Otherwise, if this is a new issue please create an issue.

[ujohnny]

I guess it is caused by #6094, @tpasternak haven't you mentioned something about this scenario to me several weeks ago?

@mmendonca2 could you please try specifying use_exclusion_patterns: false in project view file and perform sync?

[LeFrosch]

@ujohnny @tpasternak I can confirm, the exclusion of subdirectories @mmendonca2 mentioned seems to be caused by #6094.

Also, setting use_exclusion_patterns: false looks like a valid workaround.

[tpasternak]

So what's the exact directory name that has been excluded? I added the new projectview setting exactly for cases like this one

[tpasternak]

ok, we'll going to fix it soon

#6374