[beman-tidy] Implement LICENSE.APPROVED #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neatudarius
reviewed
Jul 16, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
Overall LGTM, but we have some details to figure out which may change the implementation for LICENSE.APPROVED, LICENSE.APACHE_LLVM and LICENSE.CRITERIA.
tools/beman-tidy/tests/lib/checks/beman_standard/license/test_license.py
Outdated
Show resolved
Hide resolved
neatudarius
requested review from
JeffGarland,
ednolan,
rishyak and
wusatosi
as code owners
neatudarius
requested changes
Jul 16, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
Setting proper status for this PR. We have a lead approve plan for LICENSE.* (https://github.com/bemanproject/infra/pull/135#discussion_r2210507761). We'll continue in that direction.
…n-tidy-implement-LICENSE.APPROVED
neatudarius
reviewed
Jul 17, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
here is a chunk of comments for tests
tools/beman-tidy/tests/lib/checks/beman_standard/license/test_license.py
Outdated
Show resolved
Hide resolved
tools/beman-tidy/tests/lib/checks/beman_standard/license/data/valid/LICENSE-v3
Outdated
Show resolved
Hide resolved
tools/beman-tidy/tests/lib/checks/beman_standard/license/data/valid/LICENSE-v2
Outdated
Show resolved
Hide resolved
tools/beman-tidy/tests/lib/checks/beman_standard/license/data/valid/LICENSE-v1
Outdated
Show resolved
Hide resolved
neatudarius
requested changes
Jul 17, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
here is my request related to the actual check implementation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
neatudarius
reviewed
Jul 18, 2025
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
neatudarius
reviewed
Jul 18, 2025
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
neatudarius
reviewed
Jul 18, 2025
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
[beman-tidy] Prettier regex with textwrap
neatudarius
reviewed
Jul 18, 2025
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
neatudarius
reviewed
Jul 18, 2025
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
neatudarius
reviewed
Jul 18, 2025
neatudarius
reviewed
Jul 18, 2025
neatudarius
approved these changes
Jul 18, 2025
This was referenced Jul 18, 2025
2 tasks
wusatosi
pushed a commit
that referenced
this pull request
Sep 27, 2025
….APPROVED [beman-tidy] Implement LICENSE.APPROVED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented LICENSE.APPROVED - #45