Removed wording "Roll" in Pitch sliders

[CarviFPV]

Removed the word "Roll" from the Pitch Sliders wich had confusing some Users. Issue: #4574

Summary by CodeRabbit

• Bug Fixes
  • Corrected Pitch-related labels to remove “Roll” and accurately reflect Pitch-only ratios on damping and tracking controls.
• Documentation
  • Updated PID tuning help text to match revised Pitch labels and improve wording, punctuation, and capitalization.
• Style
  • Fixed typos ("Enchances" → "Enhances", "strenght" → "strength") and standardized phrasing (e.g., "Raises or lowers") for clearer UI copy.

[coderabbitai]

Walkthrough

Updated three English localization entries in locales/en/messages.json: adjusted pitch-related labels to "Pitch: D" and "Pitch: P, I & FF", corrected punctuation/typos and capitalization in the PID sliders help text, and standardized some HTML line-break formatting.

Changes

Cohort / File(s)	Change summary
Localization updates locales/en/messages.json	Modified messages: pidTuningRollPitchRatioSlider ("Pitch:Roll D" → "Pitch: D"), pidTuningPitchPIGainSlider ("Pitch:Roll P, I & FF" → "Pitch: P, I & FF"); updated pidTuningPidSlidersHelp text for corrected labels, grammar/typos ("Enchances"→"Enhances", "strenght"→"strength"), punctuation, and standardized <br /> usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 264c55f and 37b14b3.

📒 Files selected for processing (1)

• locales/en/messages.json (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• locales/en/messages.json

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The current PR description is minimal and does not follow the repository's required template: it only states the intent and references Issue #4574 but omits required sections such as background, a summary of changed files/strings, testing or verification steps, and CI/build expectations, and it contains typographical errors ("wich"). Because these template sections and key details are missing, the description does not meet the repository's standards and is insufficient for review.	Please update the PR description using the repository template: add a brief background and rationale, list the files and exact string changes, include testing or verification steps (how you validated the strings and any UI checks), confirm branch/source details (not from master) and reference Issue #4574, and fix typos and grammar. Also mention expected CI checks or whether CI has already passed and any reviewer notes to expedite merging.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly and concisely identifies the primary change — removal of the word "Roll" from Pitch sliders — and matches the PR objectives and file summaries showing only localization string edits. It is a short, single sentence that a reviewer scanning history can understand. For consistency with other PRs you may opt for present-tense phrasing (e.g., "Remove 'Roll' from pitch slider labels"), but no change is required.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

locales/en/messages.json (1)

4538-4539: Standardize line break tag.

Use <br /> (self-closing) to match the rest of the file and avoid mixed markup.

Apply this diff:

-        "message": "Pitch Tracking:<br><i><small>Pitch: P, I & FF</small></i>",
+        "message": "Pitch Tracking:<br /><i><small>Pitch: P, I & FF</small></i>",

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25def4c and 264c55f.

📒 Files selected for processing (1)

• locales/en/messages.json (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-05-26T11:37:09.758Z

Learnt from: haslinghuis
PR: betaflight/betaflight-configurator#4490
File: locales/en/messages.json:1534-1545
Timestamp: 2025-05-26T11:37:09.758Z
Learning: In the Betaflight Configurator repository, only English messages should be added directly to `locales/en/messages.json`; other language translations are handled via Crowdin automation and should not be manually updated in PRs.

Applied to files:

• locales/en/messages.json

🔇 Additional comments (1)

locales/en/messages.json (1)

4530-4531: ```shell
#!/bin/bash
set -euo pipefail

echo '== rg --debug: pattern Pitch[:\s-]*Roll =='
rg --debug -nI --hidden -S -P -C3 'Pitch[:\s-]*Roll' || true

echo '== rg (no debug): Pitch[:\s-]*Roll =='
rg -nI --hidden -S -P -C3 'Pitch[:\s-]*Roll' || true

echo '== rg variants (Pitch.*Roll, exact etc.) =='
rg -nI --hidden -S -P -C3 'Pitch.*Roll' || true
rg -nI --hidden -S -P -C3 'Pitch:Roll' || true
rg -nI --hidden -S -P -C3 'Pitch-Roll' || true
rg -nI --hidden -S -P -C3 'Pitch Roll' || true

echo '== search for "Pitch" occurrences (context) =='
rg -nI --hidden -S -C3 'Pitch' || true

echo '== find messages.json files and search within them =='
find . -type f -name 'messages.json' -print0 | xargs -0 -r rg -n --hidden -S -P -C3 'Pitch[:\s-]*Roll' || true

echo '== show locales/en/messages.json around lines 4520-4540 =='
if [ -f locales/en/messages.json ]; then
sed -n '4520,4540p' locales/en/messages.json || true
else
echo 'locales/en/messages.json not found'
fi

echo '== done =='

</blockquote></details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

[haslinghuis]

This is intentional to signify that it is a multiplier over the roll values.

[haslinghuis]

Perhaps we keep the grammatical fixes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://37b14b31.betaflight-configurator.pages.dev

[Canaill51]

Preview URL: https://37b14b31.betaflight-configurator.pages.dev

@haslinghuis @CarviFPV , I checked your changes (in english version), this seems to be good, thanks!
How to update all language GUI?

[haslinghuis]

@Canaill51 Keeping Roll here is intentional to signify it is a multiplier over the roll values.

[haslinghuis]

@limonspb - what do you think ?

[nerdCopter]

This is intentional to signify that it is a multiplier over the roll values.

i believe this is true. : colon typically indicates a ratio -- i.e. roll to pitch ratio

[haslinghuis]

@CarviFPV do you care to update the tooltip instead to point out the ratio here ?

[CarviFPV]

@CarviFPV do you care to update the tooltip instead to point out the ratio here ?

Yes, but I’m not sure how to rephrase it. Do you have an idea?

[haslinghuis]

@nerdCopter is good in phrasing

[nerdCopter]

@coderabbitai, i'm lazy today. propose an update to ONLY the tooltip in regards to this PR conversation (only the english message.json). The idea is to explain to the general audience via the tooltip that the Roll:Pitch is a ratio.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read the current tooltip message from messages.json
cat locales/en/messages.json | jq -r '.pidTuningPidSlidersHelp.message'

Length of output: 913

---

@nerdCopter, here's my proposed update to the tooltip text to clarify the ratio concept:

"pidTuningPidSlidersHelp": {
    "message": "Sliders to adjust the aircraft flight characteristics (PID gains)<br /><br />Damping (D gain): Resists fast movement, minimises P oscillation.<br /><br />Tracking (P and I gain): Enhances the responsiveness of the aircraft; if too high, may cause trilling or oscillation.<br /><br />Stick Response (Feedforward): Increases the responsiveness of the aircraft to faster stick movements.<br /><br />Drift - Wobble (I gain, expert):  Fine adjustment of I.<br /><br />Dynamic D (D Max, expert):  Sets the maximum amount that D can be boosted to during fast movements.<br /><br />Pitch Damping (Pitch:Roll D ratio, expert): Adjusts the ratio of pitch damping relative to roll damping. Increases the amount of damping on pitch relative to roll.<br /><br />Pitch Tracking (Pitch:Roll P, I and F ratio, expert): Adjusts the ratio of pitch stabilisation relative to roll stabilisation. Increases stabilising strength on pitch relative to roll.<br /><br />Master Multiplier (all gains, expert): Raises or lowers all the PID gains, keeping their proportions constant."
}

Key changes:

1. Changed "Pitch: D ratio" → "Pitch:Roll D ratio" (no space after colon, as commonly used in ratio notation)
2. Changed "Pitch: P, I and F ratio" → "Pitch:Roll P, I and F ratio"
3. Added clarifying first sentences: "Adjusts the ratio of pitch damping relative to roll damping" and "Adjusts the ratio of pitch stabilisation relative to roll stabilisation"

This makes it crystal clear that these sliders control ratios (pitch-to-roll) while keeping the existing helpful descriptions about what they do.