chore(ci): Add retry to codecov#2032
Conversation
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK 62e854a
Any ideas why it's sometimes failing?
|
Coveralls is down haha But not sure what has been happening previously. |
|
It looks like they had some incidents in the past days: https://status.coveralls.io/incidents/6vf9p6wf702z |
|
It looks like the issue has been resolved on their side, see: https://status.coveralls.io/incidents/6vf9p6wf702z. However, I still think it's a good idea to have the retry, as it reduces the manual intervention whenever it fails for some reason. |
|
It looks like it doesn't actually have the retry/retry-delay options. See: https://github.com/bitcoindevkit/bdk/actions/runs/17996436648. The other options are either using: https://github.com/nick-fields/retry or manually implementing a retry logic. |
|
I've created a new PR #2047 reverting it. |
64934e1 fix(ci): remove retry/retry-delay (Leonardo Lima) Pull request description: ### Description It looks like that the retry approach introduced on #2032 does not really work, as the github workflow syntax does not have those fields. I've opened this PR to revert the changes, and make sure that CI is working again. Though I still think we can implement a manual retry logic on our side, probably using gh cli inside of the CI job. ### Notes to the reviewers It needs to be merged in order to coverage CI to work properly again. ### Changelog notice ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) ACKs for top commit: evanlinjin: ACK 64934e1 Tree-SHA512: 273e09bbfd841cbbcc0f57e24ae40dd0bcb68523fec684d9e380629ac6b0aab198214f8208fb48e88cfa391b3c6a427d757492da465495301cdfb44d28f6ab8c
4 participants
Description
Lots of failures lately. This reduces manual intervention needs.
Checklists
All Submissions: