Skip to content

fix(ci): remove retry/retry-delay#2047

Merged
evanlinjin merged 1 commit into
bitcoindevkit:masterfrom
oleonardolima:ci/fix-coverage-job
Sep 25, 2025
Merged

fix(ci): remove retry/retry-delay#2047
evanlinjin merged 1 commit into
bitcoindevkit:masterfrom
oleonardolima:ci/fix-coverage-job

Conversation

@oleonardolima

@oleonardolima oleonardolima commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

Description

It looks like that the retry approach introduced on #2032 does not really work, as the github workflow syntax does not have those fields.

I've opened this PR to revert the changes, and make sure that CI is working again. Though I still think we can implement a manual retry logic on our side, probably using gh cli inside of the CI job.

Notes to the reviewers

It needs to be merged in order to coverage CI to work properly again.

Changelog notice

Checklists

All Submissions:

@oleonardolima oleonardolima self-assigned this Sep 25, 2025
@oleonardolima oleonardolima added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Sep 25, 2025

@evanlinjin evanlinjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 64934e1

This is unfortunate. Looks like the CI error won't show up until after the PR is merged: https://github.com/bitcoindevkit/bdk/actions/runs/18003061193

Sorry about this, next time I'll need to triple-check my vibe-codes.

@evanlinjin evanlinjin merged commit 4031e19 into bitcoindevkit:master Sep 25, 2025
19 checks passed
@oleonardolima oleonardolima deleted the ci/fix-coverage-job branch September 25, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working github_actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants