Skip to content

[PM-18403] tech-debt: Consolidate Authenticator minSDK version, increasing it to API 29#7104

Open
vvolkgang wants to merge 2 commits into
mainfrom
vvolkgang/bwa-minsdk-cleanup
Open

[PM-18403] tech-debt: Consolidate Authenticator minSDK version, increasing it to API 29#7104
vvolkgang wants to merge 2 commits into
mainfrom
vvolkgang/bwa-minsdk-cleanup

Conversation

@vvolkgang

Copy link
Copy Markdown
Member

🎟️ Tracking

PM-18403

📔 Objective

Consolidate Authenticator minSDK version, aligning it with Password Manager. ⚠️ Authenticator minSDK increases from API 28 to 29!

@vvolkgang vvolkgang added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 25, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt labels Jun 25, 2026
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This tech-debt PR consolidates the duplicate minSdkBwa = "28" version catalog entry into the single minSdk = "29" across all 10 module build files, raising Authenticator's minSdk from API 28 to API 29 (as called out in the PR description). The consolidation is complete — no remaining minSdkBwa references and all modules now reference libs.versions.minSdk. No API 28/29-exclusive version-gated code paths are affected; the lowest SDK_INT/@RequiresApi guards in the codebase target API 30 (R) and above, so nothing is stranded by the new floor.

Code Review Details
  • ⚠️ : Published authenticatorbridge AAR minSdk raised 28 → 29 is a breaking change for external consumers; README still documents minSdk 28 and the pending CHANGELOG ### Breaking Changes section is empty. (Previously raised; author is deferring README cleanup across all modules to a follow-up PR.)
    • authenticatorbridge/build.gradle.kts:25

Note: the comment at testharness/build.gradle.kts:22 ("API 28 - CredentialManager with Play Services support") is now stale and could be updated for clarity (not blocking).

// This min value is selected to accommodate known consumers
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ IMPORTANT: Raising the published authenticatorbridge AAR minSdk 28 → 29 is a breaking change for external consumers, but the SDK's consumer-facing docs were not updated.

Details and fix

This module is a versioned, externally-consumed SDK (README "Compatibility", CHANGELOG, version = "1.0.2"), and the comment on line 23 explicitly notes the min value is "selected to accommodate known consumers." Bumping it to 29 drops support for API 28 (Android 9) consumers.

Two follow-ups within this module:

  • authenticatorbridge/README.md:17 still states **Minimum SDK**: 28 (Android 9) — now inconsistent with the build config. Update it to 29.
  • authenticatorbridge/CHANGELOG.md has a v1.1.0 (pending) entry with an empty ### Breaking Changes section — record the minSdk raise there so downstream consumers are notified.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's several other README.md that also reference 28 as the minimum version, ideally we just remove that from all of them so, that'll be sorted in a future PR.

@vvolkgang vvolkgang marked this pull request as ready for review June 25, 2026 20:38
@vvolkgang vvolkgang requested review from a team and david-livefront as code owners June 25, 2026 20:38
@vvolkgang vvolkgang marked this pull request as draft June 25, 2026 20:38
@vvolkgang vvolkgang marked this pull request as ready for review June 25, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants