[PM-18403] tech-debt: Consolidate Authenticator minSDK version, increasing it to API 29#7104
[PM-18403] tech-debt: Consolidate Authenticator minSDK version, increasing it to API 29#7104vvolkgang wants to merge 2 commits into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This tech-debt PR consolidates the duplicate Code Review Details
Note: the comment at |
| // This min value is selected to accommodate known consumers | ||
| minSdk { | ||
| version = release(libs.versions.minSdkBwa.get().toInt()) | ||
| version = release(libs.versions.minSdk.get().toInt()) |
There was a problem hiding this comment.
authenticatorbridge AAR minSdk 28 → 29 is a breaking change for external consumers, but the SDK's consumer-facing docs were not updated.
Details and fix
This module is a versioned, externally-consumed SDK (README "Compatibility", CHANGELOG, version = "1.0.2"), and the comment on line 23 explicitly notes the min value is "selected to accommodate known consumers." Bumping it to 29 drops support for API 28 (Android 9) consumers.
Two follow-ups within this module:
authenticatorbridge/README.md:17still states**Minimum SDK**: 28 (Android 9)— now inconsistent with the build config. Update it to 29.authenticatorbridge/CHANGELOG.mdhas av1.1.0 (pending)entry with an empty### Breaking Changessection — record the minSdk raise there so downstream consumers are notified.
There was a problem hiding this comment.
There's several other README.md that also reference 28 as the minimum version, ideally we just remove that from all of them so, that'll be sorted in a future PR.
🎟️ Tracking
PM-18403
📔 Objective
Consolidate Authenticator minSDK version, aligning it with Password Manager.⚠️ Authenticator minSDK increases from API 28 to 29!