Skip to content

[PM-18403] tech-debt: Consolidate Authenticator minSDK version, increasing it to API 29 #7104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vvolkgang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[PM-18403] tech-debt: Consolidate Authenticator minSDK version, increasing it to API 29 #7104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef26d6
Consolidate Authenticator minSDK version.
vvolkgang Jun 25, 2026
402d89c
Merge branch 'main' into vvolkgang/bwa-minsdk-cleanup
vvolkgang Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion annotation/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ configure<LibraryExtension> {

defaultConfig {
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down
2 changes: 1 addition & 1 deletion authenticator/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ configure<ApplicationExtension> {
defaultConfig {
applicationId = "com.bitwarden.authenticator"
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
targetSdk {
version = release(libs.versions.targetSdk.get().toInt())
Expand Down
2 changes: 1 addition & 1 deletion authenticatorbridge/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ configure<LibraryExtension> {
defaultConfig {
// This min value is selected to accommodate known consumers
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())

@claude claude Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ IMPORTANT: Raising the published authenticatorbridge AAR minSdk 28 → 29 is a breaking change for external consumers, but the SDK's consumer-facing docs were not updated.

Details and fix

This module is a versioned, externally-consumed SDK (README "Compatibility", CHANGELOG, version = "1.0.2"), and the comment on line 23 explicitly notes the min value is "selected to accommodate known consumers." Bumping it to 29 drops support for API 28 (Android 9) consumers.

Two follow-ups within this module:

  • authenticatorbridge/README.md:17 still states **Minimum SDK**: 28 (Android 9) — now inconsistent with the build config. Update it to 29.
  • authenticatorbridge/CHANGELOG.md has a v1.1.0 (pending) entry with an empty ### Breaking Changes section — record the minSdk raise there so downstream consumers are notified.

@vvolkgang vvolkgang Jun 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's several other README.md that also reference 28 as the minimum version, ideally we just remove that from all of them so, that'll be sorted in a future PR.

}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down
2 changes: 1 addition & 1 deletion core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ configure<LibraryExtension> {
// Set the minimum SDK version to the SDK version used by Authenticator, which is the lowest
// universally supported SDK version.
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down
2 changes: 1 addition & 1 deletion cxf/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ configure<LibraryExtension> {

defaultConfig {
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down
2 changes: 1 addition & 1 deletion data/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ configure<LibraryExtension> {

defaultConfig {
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down
1 change: 0 additions & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ appVersionName = "2026.6.0"
compileSdk = "37"
targetSdk = "37"
minSdk = "29"
minSdkBwa = "28"

# Dependency Versions
androidGradlePlugin = "9.2.1"
Expand Down
2 changes: 1 addition & 1 deletion network/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ configure<LibraryExtension> {

defaultConfig {
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down
2 changes: 1 addition & 1 deletion testharness/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ configure<ApplicationExtension> {
applicationId = "com.bitwarden.testharness"
// API 28 - CredentialManager with Play Services support
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
targetSdk {
version = release(libs.versions.targetSdk.get().toInt())
Expand Down
2 changes: 1 addition & 1 deletion ui/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ configure<LibraryExtension> {

defaultConfig {
minSdk {
version = release(libs.versions.minSdkBwa.get().toInt())
version = release(libs.versions.minSdk.get().toInt())
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down
Loading