Skip to content

Polish side panel motion and composer alignment#1294

Merged
wesbillman merged 2 commits into
mainfrom
kennylopez-thread-panel-open-animation
Jun 26, 2026
Merged

Polish side panel motion and composer alignment#1294
wesbillman merged 2 commits into
mainfrom
kennylopez-thread-panel-open-animation

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

Summary

  • Add a shared ease-out enter motion for right-side drawers and apply it across thread, profile, channel info, and agent activity panels.
  • Round/inset the main app surface, lock top-chrome wheel overscroll, and align composer toolbar/typing affordances with the message text start.
  • Remove the temporary typing debug fallback so typing only appears for real typing events.

Screenshots

Channel Info Drawer

Channel info drawer

Composer Typing Alignment

Composer typing alignment

Checks

  • Code checks: no findings
  • node ./scripts/check-file-sizes.mjs
  • ./node_modules/.bin/tsc --noEmit
  • node ./scripts/check-px-text.mjs
  • git diff --check
  • ./node_modules/.bin/vite build
  • ./node_modules/.bin/playwright test tests/e2e/channels.spec.ts -g "typing indicator shows avatars" --project=smoke

Note: commit/push hooks were bypassed because their pnpm/Flutter setup path was blocked by registry/tool downloads; the targeted checks above passed locally.

@klopez4212 klopez4212 marked this pull request as ready for review June 25, 2026 19:51
@klopez4212 klopez4212 requested a review from wesbillman June 25, 2026 19:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e2a514792

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/shared/styles/globals.css Outdated
#root {
height: 100%;
min-height: 100%;
overflow: hidden;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve scrolling outside the app shell

When first-run/onboarding content is taller than the window (for example the onboarding setup page can render a grid of runtime provider cards in SetupStep, while OnboardingFlow wraps it in a centered buzz-startup-shell rather than an internal scroll container), this global overflow: hidden removes the page-level scroll that previously let users reach the lower actions. In small desktop windows or with enough setup content, the bottom of the onboarding/setup flow can be clipped and inaccessible; scope the scroll lock to the app shell/top chrome path or add an explicit onboarding scroll container.

Useful? React with 👍 / 👎.

Comment thread desktop/src/shared/styles/globals.css Outdated
#root {
height: 100%;
min-height: 100%;
overflow: hidden;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d fix the global scroll lock before merging. Adding overflow: hidden to html/body/#root does stop the top-chrome overscroll, but it also applies while the startup/onboarding shells are mounted (buzz-startup-shell in App.tsx / OnboardingFlow.tsx). Those screens rely on document scrolling when their content is taller than the window, so small windows or longer setup content can get clipped with no way to reach the bottom actions.

Could we scope the scroll lock to the app-shell surface/top-chrome path instead, or give the startup/onboarding shell its own overflow-y-auto container?

Scope the overscroll fix to the app shell instead of locking html/body/root so startup and onboarding screens can still use page-level scrolling when their content is taller than the window.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman wesbillman merged commit 34b2d3e into main Jun 26, 2026
25 checks passed
@wesbillman wesbillman deleted the kennylopez-thread-panel-open-animation branch June 26, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants