Add TimeZone::utc() to FFI#358
Merged
Merged
Conversation
Contributor
Author
|
Also open to adding a generic infallible construction API for the IanaIdentifier variant. |
Manishearth
changed the title
nekevss
reviewed
Jun 20, 2025
| Box::new(Self(self.0.clone())) | ||
| } | ||
| pub fn utc() -> Box<Self> { | ||
| Box::new(Self(temporal_rs::TimeZone::IanaIdentifier("UTC".into()))) |
Member
There was a problem hiding this comment.
question: any general thoughts on how this may update with any future changes around #330.
I'm mostly concerned about how changes to TimeZone may affect this in the future.
Contributor
Author
There was a problem hiding this comment.
It seems like we're not sure about Copy TimeZones being a thing, in that case I think we should land this
Member
There was a problem hiding this comment.
I still think making this copy is the best general approach, but in the meantime agreed on moving forward as is.
Manishearth
force-pushed
the
tz-utc-ffi
branch
2 times, most recently
from
e10ccb5 to
4b504e5
Compare
Manishearth
changed the title
nekevss
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning is generally useful, and
utc()allows for infallible construction (currently there is no way to infallibly construct a timezone)