Skip to content

Add TimeZone::utc() to FFI #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manishearth merged 2 commits into from
Jul 17, 2025
Merged

Add TimeZone::utc() to FFI #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e7670
Add TimeZone::utc() to FFI
Manishearth Jul 17, 2025
68077d1
Merge branch 'main' into tz-utc-ffi
Manishearth Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions temporal_capi/bindings/c/TimeZone.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions temporal_capi/bindings/cpp/temporal_rs/TimeZone.d.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions temporal_capi/bindings/cpp/temporal_rs/TimeZone.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions temporal_capi/src/time_zone.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ pub mod ffi {
let _ = write.write_str(&s);
}

pub fn utc() -> Box<Self> {
Box::new(Self(temporal_rs::TimeZone::IanaIdentifier("UTC".into())))

@nekevss nekevss Jun 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: any general thoughts on how this may update with any future changes around #330.

I'm mostly concerned about how changes to TimeZone may affect this in the future.

@Manishearth Manishearth Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we're not sure about Copy TimeZones being a thing, in that case I think we should land this

@nekevss nekevss Jul 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think making this copy is the best general approach, but in the meantime agreed on moving forward as is.

}

#[allow(clippy::should_implement_trait)]
pub fn clone(&self) -> Box<TimeZone> {
Box::new(TimeZone(self.0.clone()))
Expand Down
Loading