Skip to content

front-desk-add: fail open when the Front Desk App is unset #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdelanghe merged 1 commit into from
Jun 22, 2026
Merged

front-desk-add: fail open when the Front Desk App is unset #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/front-desk-add.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
# Auth = the Front Desk *door*: the same signed GitHub App, granted only
# Organization Projects: read+write (+ repo Issues/PRs: read).
# Configure ONCE as ORG-level var + secret so every repo shares them:
# - org variable FRONT_DESK_APP_ID
# - org variable FRONT_DESK_CLIENT_ID (the App's Client ID, Iv23…)
# - org secret FRONT_DESK_APP_PRIVATE_KEY
# (See docs/handoffs/gh-project-room.md → "The door".)
#
# Until those are set, the job FAILS OPEN: the credentialed steps are gated on
# FRONT_DESK_APP_ID and skipped, so the `add` check passes instead of dying on
# FRONT_DESK_CLIENT_ID and skipped, so the `add` check passes instead of dying on
# every PR org-wide (the bug in docs/handoffs/front-desk-app-credentials.md).
# The central sweep (front-desk-sync.yml) is the backstop until the org-level
# var + secret land.
Expand All @@ -33,23 +33,23 @@ jobs:
runs-on: ubuntu-latest
steps:
# Fail OPEN when the Front Desk App isn't configured yet: an unset
# org var FRONT_DESK_APP_ID means the token mint (and thus the whole
# org var FRONT_DESK_CLIENT_ID means the token mint (and thus the whole
# job) would fail on every PR. Skip the credentialed steps and let the
# job pass — the central sweep (gh-project-room) is the backstop until
# the org-level var + secret are set.
- name: Front Desk App not configured — skipping
if: ${{ vars.FRONT_DESK_APP_ID == '' }}
run: echo "FRONT_DESK_APP_ID unset; relying on the central sweep. See docs/handoffs/gh-project-room.md."
if: ${{ vars.FRONT_DESK_CLIENT_ID == '' }}
run: echo "FRONT_DESK_CLIENT_ID unset; relying on the central sweep. See docs/handoffs/gh-project-room.md."
- name: Mint Front Desk token from the GitHub App
id: app-token
if: ${{ vars.FRONT_DESK_APP_ID != '' }}
uses: actions/create-github-app-token@fee1f7d63c2ff003460e3d139729b119787bc349 # v2.2.2
if: ${{ vars.FRONT_DESK_CLIENT_ID != '' }}
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
app-id: ${{ vars.FRONT_DESK_APP_ID }}
client-id: ${{ vars.FRONT_DESK_CLIENT_ID }}
private-key: ${{ secrets.FRONT_DESK_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
- name: Add to Front Desk
if: ${{ vars.FRONT_DESK_APP_ID != '' }}
if: ${{ vars.FRONT_DESK_CLIENT_ID != '' }}
uses: actions/add-to-project@244f685bbc3b7adfa8466e08b698b5577571133e # v1.0.2
with:
project-url: https://github.com/orgs/bounded-systems/projects/2
Expand Down
Loading