Repository navigation
feat(libSceHttp): accept the SSL version, SSL error and redirect and cookie callback calls - #1206
Merged
Conversation
This was referenced Oct 7, 2026
9 tasks done
7 of 9 tasks
9 tasks done
…cookie callback calls No request reaches the network, so sceHttpsSetSslVersion has no TLS connection to configure, sceHttpSetRedirectCallback and sceHttpSetCookieRecvCallback register callbacks that are never called, and sceHttpsGetSslError reports error 0 with detail 0. A null errNum or detail returns SCE_HTTP_ERROR_INVALID_VALUE like sceHttpGetLastErrno. Signatures follow shadPS4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Checked the signatures against shadPS4 and SharpProspero (they agree), the callback typedefs against shadPS4, and the TechnicalDebt entries (silent stub, signature source, PPSA23566 line removed). |
adriadam10
force-pushed
the
feat/http-ssl-and-callbacks
branch
from
October 8, 2026 09:09
5ddaf24 to
3ed954f
Compare
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements
sceHttpsSetSslVersion,sceHttpsGetSslError,sceHttpSetRedirectCallbackandsceHttpSetCookieRecvCallback. Before this change they were declared without parameters and threw (PPSA23566 imports).No request reaches the network, so:
sceHttpsGetSslErrorreports error 0 with detail 0.A null
errNumordetailreturnsSCE_HTTP_ERROR_INVALID_VALUE, assceHttpGetLastErrnodoes. Signatures follow shadPS4. Adds theHttpRedirectCallbackandHttpCookieRecvCallbacktypes toSceTypes.hpp. TechnicalDebt changes:Tested
Ubuntu 24.04, GCC 13.3, Release build.
guest_httppasses with new checks: each setter returns 0,sceHttpsGetSslErrorwrites 0/0, and a nullerrNumordetailreturnsINVALID_VALUE. The fullctestrun also passes, exceptagc_driver_flip, which failed only under-j8and passes when run alone.Also checked on Windows 11 (MinGW GCC Release build):
guest_httppasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code