Repository navigation
Conversation
Extract the approximate reverb rack and DSP from the combined fork, including parameter diagnostics and rounded-boundary handling. Test the same model through core and native libraries. Console output equivalence remains unverified and is documented in TechnicalDebt. AI-assisted: yes.
|
Rebased on Fedora 44 Release: |
1a4a2b0 to
70b4d2d
Compare
|
Reviewed against main The overlap is substantial, but this draft also accepts channel conversion that main still rejects: a fresh Skyrim boot with rebuilt main libraries reaches Vulkan setup, then throws The description retains the unchecked reference requirement. This draft may serve as an explicitly named, identical support dependency on both sides of local title benchmarks, which is separate from validating it for merging. No console equivalence is claimed. AI-assisted review. |
|
Further integration check: the unmerged implementation does provide a distinct channel-conversion path. Loading its entire old NGS library first got past main's reverb conversion error but dropped main's newer panning implementation ( Skyrim PPSA03747 now reaches recurring draws/dispatches with that common test dependency; a 180-second run completed to the imposed time limit without the original audio exception. This is useful as a shared integration baseline for graphics experiments. It is not vanilla main, a console reference check, or a claim of correct/complete game rendering. The source diff and binary hashes are recorded locally. This PR remains a draft. Main's reference-checked equal-channel DSP should be preserved in any mergeable rework, and missing channel conversion needs its own reference validation. The approximate old DSP should not replace the newer implementation just to obtain a boot. AI-assisted integration investigation. Artifact correction: the title runtime copies were subsequently found to contain the same patched main AGC library. The saved PRESS ANY BUTTON frame therefore validates the main + experimental NGS integration, not #1312 or #1313. The CTests/CPU benchmarks used the new unpatched builds and remain valid. The earlier PR-specific title claim is withdrawn; corrected results follow. Corrected runtime result: the NID-patched #1312 library has SHA-256 |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
What
Draft with overlapping upstream DSP work. Current
main(d146ec1b6) already implements this rack and its I3DL2 controls. In particular,e15f1644e384ab055f721347a4d31cdff02e9a47replaced the earlier approximation with the implementation checked against PS4 firmware 11.00 output;473ca04b2rejects unsupported rack sizes and sample rates. Main retains the PS5-comparison limitation in TechnicalDebt.This branch contains an unverified eight-line feedback delay network and channel conversion that current main still rejects. A fresh Skyrim boot on main d146ec1 reaches Vulkan setup and then throws
NGS2: reverb channel conversion is not implemented. The draft therefore retains a distinct compatibility experiment, although its DSP should not replace the newer reference-based implementation. A mergeable version must preserve that implementation and establish the missing channel-conversion semantics. The experimental revision may be used as an explicitly identified, identical support dependency on both sides of title benchmarks; this does not establish console equivalence.Tested
This follow-up is a source/history review, not a new console or game run. The earlier Fedora 44 software-model tests only established this branch's internal behavior, not console equivalence, and do not validate replacement of the current implementation.
Checklist
Integration follow-up
A separate main-based test library combining current panning/ATRAC9 with this branch's experimental reverb now gets PPSA03747 into recurring draws and dispatches. This is an integration baseline, not vanilla-main or console-validation evidence. The draft still needs the reference-preserving DSP/channel-conversion rework described above.
Title artifact correction
A binary-hash audit found that the earlier title runtime copies all contained the same patched main AGC library. Those runs establish the main + experimental NGS baseline only. They do not validate #1312/#1313 in-game. The separately built CTests and CPU benchmarks used the new unpatched libraries/source and remain valid. The earlier PR-specific title claim is withdrawn; corrected results follow.
Verified runtime rerun
Corrected runtime result: the NID-patched #1312 library has SHA-256
a15e22c1b1305f79ab39089c7640ab9b6dd0fb9e6bffc0910d053cddfc7d51eb, differs from baseline, and contains the fingerprint verification code./procconfirms the game loaded that file and the shared experimental NGS library. A fresh 120-second run withAPS5_VERIFY_REGISTER_KEYS=1reported at least 1,706 register-key lookups, no fingerprint mismatch, and presented frames. It stopped at the imposed timeout (124). No performance comparison is claimed with this verification enabled.