Repository navigation
fix(libSceRazorCpu): add sceRazorCpuNamedSync export - #1693
Conversation
|
Which Killzone Liberation title ID is this, and what's the log line where it stops on main? Please also fill in the template's |
|
Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head
No title was run. 🤖 Addressed by Claude Code |
d228ead to
2de3327
Compare
|
Checked build and full ctest on Linux on top of current main ( Pushed one commit on your branch:
I also set |
adriadam10
left a comment
There was a problem hiding this comment.
The code is fine as it stands (including the label argument commit I pushed), but the conventions check is still red: AI-assisted in the PR body still reads <!-- yes / no -->. Please edit the description and answer it with yes or no. It's the only thing failing; I'll merge once conventions is green.
@oneandonlydean's question is still open too: which title ID is this, and where does it stop on main?
|
Ready to merge from my side, but the PR description fails the conventions check:
Please fill those template lines in (only you can answer AI-assisted); it merges once they pass. |
|
Just Updated description |
|
Which title ID is Killzone Liberation here, and what is the log line where it stops on main? |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
Resolve the XCuZoBSVFG8 import required by Killzone Liberation by adding sceRazorCpuNamedSync as a no-op returning success when capture is inactive. Extend the RazorCpu behavior test and document the NID source and unverified console signature and capture behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2de3327 to
b35caff
Compare
|
Rebased onto main (e751dd2), keeping both commits and their authors. The only conflicts were next to the new |
Dismissing as stale: the only change asked for here was the AI-assisted answer in the PR body, which julienlgy filled in on 10-11, and conventions passed on the head at the time right after (https://github.com/boykopovar/AnyPS5/actions/runs/38129760459/job/114441468367). @adriadam10 said it was ready to merge from their side once that passed (#1693 (comment)). The branch has since been rebased onto main with no code change beyond conflict resolution.
What
Resolve the XCuZoBSVFG8 import required by Killzone Liberation by adding sceRazorCpuNamedSync as a no-op returning success when capture is inactive.
Extend the RazorCpu behavior test and document the NID source and unverified console signature and capture behavior.
Tested
Windows, Killzone Liberation
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)