Skip to content

fix(libSceRazorCpu): add sceRazorCpuNamedSync export - #1693

Merged
oneandonlydean merged 2 commits into
boykopovar:mainfrom
julienlgy:feat/razor-cpu-named-sync
Oct 17, 2026
Merged

oneandonlydean merged 2 commits into
boykopovar:mainfrom
julienlgy:feat/razor-cpu-named-sync

Conversation

@julienlgy

@julienlgy julienlgy commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

What

Resolve the XCuZoBSVFG8 import required by Killzone Liberation by adding sceRazorCpuNamedSync as a no-op returning success when capture is inactive.

Extend the RazorCpu behavior test and document the NID source and unverified console signature and capture behavior.

Tested

Windows, Killzone Liberation

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • [] New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • AI-assisted: yes

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Progress report (2d16248 → b35caff)

➖ System libraries: 89.39% (+0.0%, +1 implemented functions)

✅ 1 implemented
Library Name
libSceRazorCpu sceRazorCpuNamedSync
⚪ 1 behaviourally empty (constant return or throw)
Library Name
libSceRazorCpu sceRazorCpuNamedSync

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Which Killzone Liberation title ID is this, and what's the log line where it stops on main? Please also fill in the template's Depends on (none) and answer AI-assisted with yes or no; that's what the conventions check is failing on.

@popcoder565

Copy link
Copy Markdown
Contributor

Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head d228ead7, merged onto main d70b899 in one build with 38 other PRs that had no Windows run.

No title was run.

🤖 Addressed by Claude Code

@adriadam10

Copy link
Copy Markdown
Collaborator

Checked build and full ctest on Linux on top of current main (guest_razor_cpu passes), plus @popcoder565's Windows run above.

Pushed one commit on your branch:

  • sceRazorCpuNamedSync now takes const char* label: SharpProspero documents it as the named frame-boundary event (RazorCpu.cs), shadPS4's argument-less stub is not the signature. The test passes a label and the TechnicalDebt line says where each part comes from.

I also set Depends on: none in the PR body. Still needed from you: answer AI-assisted (yes/no) in the PR body, the only thing the conventions check still fails on, and @oneandonlydean's question about the title ID and where it stops on main. Merging once conventions and CI are green.

@adriadam10 adriadam10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine as it stands (including the label argument commit I pushed), but the conventions check is still red: AI-assisted in the PR body still reads <!-- yes / no -->. Please edit the description and answer it with yes or no. It's the only thing failing; I'll merge once conventions is green.

@oneandonlydean's question is still open too: which title ID is this, and where does it stop on main?

@adriadam10

Copy link
Copy Markdown
Collaborator

Ready to merge from my side, but the PR description fails the conventions check:

  • [pr-template] Fill in the pull request template: answer AI-assisted with yes or no

Please fill those template lines in (only you can answer AI-assisted); it merges once they pass.

@julienlgy

Copy link
Copy Markdown
Contributor Author

Just Updated description

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Which title ID is Killzone Liberation here, and what is the log line where it stops on main?

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 6044 core/libs/tests/GuestRazorCpu.cpp

This was referenced Oct 15, 2026
julienlgy and others added 2 commits October 17, 2026 13:06
Resolve the XCuZoBSVFG8 import required by Killzone Liberation by adding sceRazorCpuNamedSync as a no-op returning success when capture is inactive.

Extend the RazorCpu behavior test and document the NID source and unverified console signature and capture behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@oneandonlydean
oneandonlydean force-pushed the feat/razor-cpu-named-sync branch from 2de3327 to b35caff Compare October 17, 2026 01:37
@oneandonlydean

Copy link
Copy Markdown
Collaborator

Rebased onto main (e751dd2), keeping both commits and their authors. The only conflicts were next to the new sceRazorCpuPushMarker in Export.cpp and GuestRazorCpu.cpp (kept both), and the debt entry moved to docs/dev/debt/libSceRazorCpu.md. It builds and guest_razor_cpu passes locally, and it still merges cleanly with current main. Full CI is running on the new head.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 17, 2026
@oneandonlydean
oneandonlydean dismissed adriadam10’s stale review October 17, 2026 01:47

Dismissing as stale: the only change asked for here was the AI-assisted answer in the PR body, which julienlgy filled in on 10-11, and conventions passed on the head at the time right after (https://github.com/boykopovar/AnyPS5/actions/runs/38129760459/job/114441468367). @adriadam10 said it was ready to merge from their side once that passed (#1693 (comment)). The branch has since been rebased onto main with no code change beyond conflict resolution.

@oneandonlydean oneandonlydean self-assigned this Oct 17, 2026
@oneandonlydean
oneandonlydean merged commit f643e61 into boykopovar:main Oct 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants