Repository navigation
test(libc): register the macOS write watch fault tests once - #13220
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Supplementary current-main configuration repro and CI impact for exact head Main This also explains the red write-watch checks on the approved math PRs #10113, macOS Intel job and #10226, macOS ARM job: both stop at this same CMake error before testing the math implementation. Their source branches remain unchanged. My check ran on Linux and covers configuration/test registration only. A standalone build reaches the expected platform limit ( Main/fix configuration logs, generated-registration list, public patch and build limitation — SHA-256 |
|
Thanks for merging this on November1. Several owned PRs still show older macOS write-watch failures from before the merge. I inspected #12122's macos-15 job: configuration stops because Please initiate fresh qualification against current main for the affected unchanged heads (#13119, #12598, #12592, #12514, #12122, #12053, #10345, #10328, #10325, #10321, #10234, #10229, #10226 and #9688). I have not treated the old failures as passes or assumed that every failure has the same cause. The three branches freshly rebased in this pass have new CI runs and are excluded from this list. My upstream access cannot initiate the required job reruns. The separate Windows |
What
core/libs/tests/write_watch/CMakeLists.txtregisters theexecute-faultandread-faultwrite watch tests twice: #12117 (eb20686c42) and #12435 (1f1da4b0ff) each added the sameforeach(mode execute-fault read-fault)block, and both are onmain. The directory is added only on macOS (if(APPLE)incore/libs/CMakeLists.txt), so on macOS with tests enabled CMake stops while configuring:and the same for
write_watch_read-fault, which also blocks every build in that tree. This removes the second block. Linux and Windows do not add the directory and are unaffected.Tested
Apple M5 Pro, macOS 27.2, x86-64 Release under Rosetta 2.
mainalone does not build on macOS; I configured and built in a tree with the open macOS port PRs merged with today'smain, where the file is identical to this branch's.BUILD_TESTING=ONfails with the error above.write_watch_testsandwrite_watch_backing_testsbuild, andctest -R '^write_watch_'passes 18 of 18, withwrite_watch_execute-faultandwrite_watch_read-faultlisted once each.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)main🤖 Generated with Claude Code