Repository navigation
feat(font): accept libSceFontFt format support functions as silent stubs - #1450
Closed
camezaro-intc wants to merge 1 commit into
Closed
camezaro-intc wants to merge 1 commit into
camezaro-intc wants to merge 1 commit into
Conversation
9 tasks done
adriadam10
requested changes
Oct 8, 2026
adriadam10
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR. Requested changes:
core/libs/prx/libSceFontFt/Export.cpp:34-88: these are silent stubs for non-UI behaviour. On the console the functions register format drivers with FreeType, and we have no evidence of which arguments a title passes or what it expects back. CONTRIBUTING reserves silent no-ops for UI behaviour, and unverified exports must keep throwing. shadPS4's versions are(STUBBED) return ORBIS_OKwith no parameters, so they give neither a signature nor behaviour; "as shadPS4 does" only describes an empty stub. KytyPS5, prosper and prospero-win don't implement them.- No title evidence: none of the imports we have static data for (Astro's Playroom) uses them, and no Game bring-up Discussion names them. Please point to a title (PPSAxxxxx) that calls one of these and fails on the
NotImplementedthrow today, or the throw stays. With that evidence, also say what the call contract is (args, return) and where it comes from. - #1498 changes the same 14 functions in
Export.cpp. List it under Depends on (or coordinate which of the two lands) so one doesn't break the other. core/libs/tests/GuestFont.cpp:137-150: the test only pins the0the stub returns itself. If the stubs stay, it should check something observable, such as a font created and rendered after the calls.
Contributor
Author
|
Thanks for the detailed review and explanation @adriadam10! Understood completely regarding the project's policy on silent stubs: non-UI exports must continue to throw Appreciate the guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accept the 14
libSceFontFtformat support functions (sceFontFtSupportBdf,sceFontFtSupportCid,sceFontFtSupportFontFormats,sceFontFtSupportOpenType,sceFontFtSupportOpenTypeOtf,sceFontFtSupportOpenTypeTtf,sceFontFtSupportPcf,sceFontFtSupportPfr,sceFontFtSupportSystemFonts,sceFontFtSupportTrueType,sceFontFtSupportTrueTypeGx,sceFontFtSupportType1,sceFontFtSupportType42,sceFontFtSupportWinFonts) as silent stubs returning0(SCE_FONT_OK).In the console SDK, these functions register font format drivers with the FreeType subsystem. In AnyPS5 (as in shadPS4), all supported font formats are compiled and built directly into FreeType, making additional format registration unnecessary. Returning success allows titles initializing font format drivers to proceed cleanly without throwing
NotImplemented.Documented under
### Silent stubsindocs/dev/TechnicalDebt.mdand added unit test assertions tocore/libs/tests/GuestFont.cpp.Tested
guest_font_teststarget and ran CTestguest_font(passed 100%)tools/check_conventions.py --base upstream/main(passed 0 findings)Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)