Repository navigation
feat(libs): implement font, libc, libkernel and misc prx stubs - #1498
Thomas73737 wants to merge 1 commit into
Conversation
- libSceFont/libSceFontFt: attribute, script language, typographic design, words, text layout and FreeType rendering paths - libc/libSceLibcInternal: locale data, heap diagnostics, vsnprintf, forced TLS destructor - libkernel: sceKernelFcntl, page table stats, module info, coredump debug text, exception handling, pthread_cancel - libScePsml_debug/libSceSystemGesture/libSceVoiceQoS: real state machines instead of stubs
fc364b8 to
7f0951c
Compare
klosixgaming-arch
left a comment
klosixgaming-arch
left a comment
There was a problem hiding this comment.
Excellent comprehensive implementation of multiple libSceFont, libScePsml_debug, and libSceAgcDriver functions. This significantly improves compatibility with titles using these libraries.
Strengths:
- Clean implementation of command buffer submission in libSceAgcDriver with proper null checks and guest memory validation
- Comprehensive font rendering support including glyph image rendering (horizontal/vertical), attribute management, script/language settings, and typographic design
- Proper FreeType module detection for various font format support queries
- Good PSML MFSR implementation with shared resources initialization and context management
Technical notes:
- The approach of using templates for font state updates (
UpdateFontState,ReadFontState) is clean and reduces code duplication - Proper error handling throughout with appropriate SCE error codes
- Good use of magic numbers for object validation (SHARED_RESOURCES_MAGIC, CONTEXT_MAGIC)
- FreeType support queries correctly check for specific modules rather than assuming all are available
This will improve compatibility with many titles that use font rendering and PSML features. Ready to merge.
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
|
Audited this the way the progress page would see it, because the count is defined by calling The good part first. The 15 What needs a decision before this merges. Three ways out, in the order I would pick them:
Two structural notes, both from measurement rather than opinion. The change spans 13 libraries across 24 source files (11 in I have the full per-function classification (name, file, replacement body) and can paste it or attach it as a file if that helps you act on it — say which and it is yours. Written with AI assistance. |
|
The full classification, as promised. The headline is that the biggest chunk of this PR is a message improvement rather than an implementation: So the FontFt, libc, libkernel, Psml_debug, SystemGesture, VoiceQoS and AgcDriver parts are real work — and Per-function classification of every conversion in this PR, so it can be acted on without re-deriving it. Method. For each function that calls Still unsupported after the changelibSceAgcDriver (1)
libSceFont (63)
libSceFontFt (5)
libScePsml_debug (9)
libc (1)
The real implementations (for contrast)libSceAgcDriver (2): libSceFontFt (14): libScePsml_debug (13): libSceSystemGesture (13): libSceVoiceQoS (12): libc (17): libkernel (11): |
|
Closing: this spans four libraries, names no title, and as the audit above shows, 79 of the 161 conversions only swap the throw for |
|
Thanks for the audit, @Dextroid17 and @oneandonlydean — I've acted on it. Reopening was blocked because the head branch was force-pushed (GitHub limitation), so this is continued in #2193 (same branch, rebased onto current What changed in response to the audit:
Honest numbers after the fix: libraries |
What
Implements library exports that were still unimplemented on
main, in four areas:vsnprintfconversions, the forced TLS destructor pass and the atomic assert helper.sceKernelFcntl, select-based sockets (including UDP), page table statistics, module info, coredump debug text output,pthread_cancel,pthread_attr_setsolosched_npand__tls_get_addron Linux.Every unimplemented path still throws
NotImplemented_nid_no_patch; the silent stubs that remain are documented indocs/dev/TechnicalDebt.mdin this pull request.Tested
CMAKE_BUILD_TYPE=Release).ninja -C build: builds clean.ctest --test-dir build -j4: 424/425 pass. The single failure isguest_random, which is environmental:std::random_devicereturns the constant0xFFFFFFFFon this machine, reproduced by a standalone program with no project code involved.python3 tools/progress.py: libraries 2737/3000 (91.23%) against 2552/2997 (85.15%) onmain(+185 functions); shaders unchanged at 1131/1166.python3 tools/check_conventions.py --base origin/main --head HEAD: passed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)