Repository navigation
refactor(libScePsml_debug): name the Mfsr2 stubs by their NIDs - #1467
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
9 tasks done
Collaborator
|
Checked the nine names against Note: #1498 rewrites the same nine stubs, so it will need to rebase after this lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #1144, which named the
scePsmlMfsr*stubs and left the 9scePsmlMfsr2Unknown_*ones because the NID database has no names for them. The names were found by hashing candidate names built from the existingscePsmlMfsr*names, and each one is checked with bothcompute_nidintools/nid_names.pyandNid::ComputeNidincore/libs/nid/src/NidCompute.cpp:0GAw7SmkwIIscePsmlMfsr2ReleaseSharedResources1ic5q-kdOscscePsmlMfsr2GetSharedResourcesInitRequirement5z2gBlqxJ+0scePsmlMfsr2GetContextInitRequirementKyy1baXgaVUscePsmlMfsr2ReleaseContextZLL31lzzxr4scePsmlMfsr2GetDispatchPacketsSizeInDwordsgMduXCLYrNgscePsmlMfsr2CreateSharedResourceslrJwpLjKXRcscePsmlMfsr2GetDispatchPacketsm9JLPc3wOQwscePsmlMfsr2CreateContexto+NM86gEwFEscePsmlMfsr2InitThe stubs drop
APS5_EXPORTand use these names, so the generated NIDs are unchanged andNotImplementedfailures name the real function. Behaviour is unchanged. The TechnicalDebt entry now lists the names; the signatures are still unknown.Check:
Tested
tools/nid_names.pyno longer lists anylibScePsml_debugNID.tools/check_conventions.py --base origin/mainpasses.clang++ -fsyntax-onlyon the file has no errors. No x86-64 toolchain on this machine (Apple Silicon), so the build is left to CI. No title tested.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code