Skip to content

refactor(libkernel): name the Jrs7UUkGOFo Coredump stub by its NID - #1469

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
arvindfroi:refactor/coredump-stopinfo-gpu-name
Oct 8, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
arvindfroi:refactor/coredump-stopinfo-gpu-name

Conversation

@arvindfroi

@arvindfroi arvindfroi commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

What

Jrs7UUkGOFo in libkernel's Coredump exports is sceCoredumpGetStopInfoGpu_Agc. The stub drops APS5_EXPORT and uses the name, so the generated NID is unchanged and the NotImplemented failure names the function. Behaviour is unchanged.

The NID database has sceCoredumpGetStopInfoCpu and sceCoredumpGetStopInfoGpu but not this one. The name was found by hashing candidates built from the database's sceCoredump* names, and checked with both compute_nid in tools/nid_names.py and Nid::ComputeNid in core/libs/nid/src/NidCompute.cpp:

$ python3 -c "import sys; sys.path.insert(0,'tools'); from nid_names import compute_nid; print(compute_nid('sceCoredumpGetStopInfoGpu_Agc'))"
Jrs7UUkGOFo

Tested

tools/nid_names.py no longer lists Jrs7UUkGOFo. tools/check_conventions.py --base origin/main passes. clang++ -fsyntax-only on the file has no errors. No x86-64 toolchain on this machine (Apple Silicon), so the build is left to CI. No title tested.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • AI-assisted: yes (Claude Code, Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Progress report (61896de → c7083aa)

➖ System libraries: 85.15% (+0.0%, +1 declared, -1 removed functions)

🆕 1 declared as stubs
Library Name
libkernel sceCoredumpGetStopInfoGpu_Agc
🗑️ 1 removed
Library Name
libkernel sceCoredumpUnknown01

@adriadam10

Copy link
Copy Markdown
Collaborator

Checked the NID (sceCoredumpGetStopInfoGpu_Agc hashes to Jrs7UUkGOFo), local build + ctest (462/462) and the conventions check on top of current main; merging once CI is green. Note #1498 touches the same block in Coredump.cpp, so whichever lands second needs a trivial rebase.

@adriadam10
adriadam10 merged commit 29e533a into boykopovar:main Oct 8, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants