Repository navigation
refactor(libkernel): name the Jrs7UUkGOFo Coredump stub by its NID - #1469
Merged
adriadam10 merged 1 commit intoOct 8, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9 tasks done
Collaborator
|
Checked the NID ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Jrs7UUkGOFoin libkernel's Coredump exports issceCoredumpGetStopInfoGpu_Agc. The stub dropsAPS5_EXPORTand uses the name, so the generated NID is unchanged and theNotImplementedfailure names the function. Behaviour is unchanged.The NID database has
sceCoredumpGetStopInfoCpuandsceCoredumpGetStopInfoGpubut not this one. The name was found by hashing candidates built from the database'ssceCoredump*names, and checked with bothcompute_nidintools/nid_names.pyandNid::ComputeNidincore/libs/nid/src/NidCompute.cpp:Tested
tools/nid_names.pyno longer listsJrs7UUkGOFo.tools/check_conventions.py --base origin/mainpasses.clang++ -fsyntax-onlyon the file has no errors. No x86-64 toolchain on this machine (Apple Silicon), so the build is left to CI. No title tested.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code