Repository navigation
feat(libc): implement std::_Atomic_assert - #1598
Closed
danielepoterti wants to merge 1 commit into
Closed
danielepoterti wants to merge 1 commit into
danielepoterti wants to merge 1 commit into
Conversation
The import was a throwing stub in Export.cpp, kept as a dead import of Cyberpunk 2077 (no call sites) that the Windows loader resolves strictly. It now sits with the other _Atomic_ helpers in RuntimeSupport.cpp and throws std::runtime_error carrying both string arguments, with "(null)" for a null pointer. The mangled name gives two const char* parameters. Naming them expression and file follows the usual assert handler order (__assert_fail, _wassert); no source confirms the order for this library.
9 tasks done
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
Author
|
Closing in favour of #1498, which already implements std::_Atomic_assert; I missed it before opening this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import was a throwing stub in Export.cpp, kept as a dead import of Cyberpunk 2077 (no call sites) that the Windows loader resolves strictly. It now sits with the other Atomic helpers in RuntimeSupport.cpp and throws std::runtime_error carrying both string arguments, with "(null)" for a null pointer.
The mangled name gives two const char* parameters. Naming them expression and file follows the usual assert handler order (__assert_fail, _wassert); no source confirms the order for this library.
What
Implement
std::_Atomic_assert(_ZSt14_Atomic_assertPKcS0_) in libc.The export was a throwing stub in
Export.cpp, kept for a dead import of Cyberpunk 2077 that the Windows loader resolves strictly. It now sits with the other_Atomic_helpers inRuntimeSupport.cppand throwsstd::runtime_errorcarrying both string arguments ("(null)"for a null pointer).The mangled name gives two
const char*parameters. The namesexpressionandfilefollow the usual assert handler order (__assert_fail,_wassert); no source confirms the order for this library.guest_atomic_assertchecks the message for both strings and for null pointers, on every platform.Tested
Windows 11, MinGW-w64 GCC 15.2.0 (WinLibs r7): built
libc,guest_atomic_assertpasses; checked that it fails with the wrong expected message. Linux not tested locally.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)