Repository navigation
feat(libSceNpMatching2): check sceNpMatching2GetUserInfoList requests offline - #16108
Open
MarrasFederico wants to merge 1 commit into
Open
MarrasFederico wants to merge 1 commit into
MarrasFederico wants to merge 1 commit into
Conversation
12 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceNpMatching2GetUserInfoListthrew for every call. Firmware 13.42, run natively in #12623, showed an order unlike the other requests: a null parameter (0x80550C0A), then the context, then the parameter contents. A zeroed parameter gaveCONTEXT_NOT_FOUND(0x80550C06) on an unknown context,0x80550C3Bon the A context 258, andINVALID_SERVER_ID(0x80550C0C) on context 1.The export now follows that order: not initialized, null request or request id, unknown context, A context (
0x80550C3B,INVALID_CONTEXTin shadPS4's np_error.h), then server id 0. A request that passes them still throws: the run did not show how an accepted request completes offline.sceNpMatching2GetUserInfoListAis unchanged.Not measured on a console.
Tested
Ubuntu 26.04.1, kernel 7.0.0, GCC 15.2.0, Release,
BUILD_TESTING=ON, on main6e6dae4e8b. Windows and macOS were not compiled here. No title was run.guest_np_matching2_offlinepasses. New cases: before initialization; a null request on known and unknown contexts; a null request id; a zeroed request on context 99, on the A context and on context 1.an A context did not return 0x80550C3B; restoring it passes.check_conventions.py --base upstream/mainpasses.pr_overlap.py: #15476 adds test cases next to these inGuestNpMatching2Offline.cpp, without implementing this export; that hunk needs a merge whichever lands second. My #16109 adds its debt line and tests in the same spots. #14212 only respaces the debt file.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)