Repository navigation
feat(libSceNpMatching2): refuse a null sceNpMatching2SendRoomMessage parameter before initialization - #16109
Open
MarrasFederico wants to merge 1 commit into
Conversation
…parameter before initialization
12 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceNpMatching2SendRoomMessagethrew for every call. Firmware 13.42, run natively in #12623, refused a null parameter withINVALID_ARGUMENT(0x80550C0A) even beforesceNpMatching2Initialize, where every other request returnsNOT_INITIALIZED(0x80550C03) first.The export now does exactly that: a null request returns
INVALID_ARGUMENTwhether or not the library is initialized, and a non-null request before initialization returnsNOT_INITIALIZED. Anything else still throws: the run never got past the parameter's own checks, so they and the accepted path are unknown. The request id and the context are not checked, because their place in the order was not measured.Not measured on a console.
Tested
Ubuntu 26.04.1, kernel 7.0.0, GCC 15.2.0, Release,
BUILD_TESTING=ON, on main6e6dae4e8b. Windows and macOS were not compiled here. No title was run.guest_np_matching2_offlinepasses. New cases: a null request before initialization, with and without a request id; a non-null request before initialization and after termination; a null request on a created and an unknown context.a null request before initialization did not return INVALID_ARGUMENT; restoring them passes.check_conventions.py --base upstream/mainpasses.pr_overlap.py: no overlap beyond #14212, which only respaces the debt file. My #16108 adds its debt line and tests in the same spots, so whichever merges second needs a trivial merge.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)