Repository navigation
fix(libSceHttp): retain request-status callbacks with the guest ABI - #2788
Conversation
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
|
Reopened. There is a conflict in |
|
Rebased onto current main (the only conflict was adjacency in |
e01b6bc to
63d2911
Compare
|
Additional platform validation of standalone PR head Windows: passed — Windows 11, WinLibs GCC 15.2.0 UCRT/POSIX/SEH r7; CMake 4.3.1 / Ninja; Release, 1 checks, 0 failures, 0 CTest skips. Built the selected targets and dependencies; this is focused validation, not a full build or full-suite run. Checks: Command after building: No title/gameplay validation. These results cover the standalone head, not a merge with current main. |
What
Split from #1616, following its review. Retain request-status callbacks and user data using the three-argument ABI from shadPS4; remove registrations when requests are deleted. The offline backend never dispatches callbacks.
Unknown function inforecords the uncited invalid-id error0x80431100and incomplete hierarchy/deletion validation; the entry sits inside the section, away from recent insertions.Tested
Linux x86-64, GCC 16.2.1, Release.
guest_httppasses, including callback registration, replacement, removal and invalid ids. MinGW C++20 syntax check passes; Windows runtime/CI has not been run locally. Conventions and whitespace checks pass on current main (5edae353).Depends on
None for build. HFW integration also needs #2785 (relinker), #2786 (loader), #2787 (filesystem), #2789 (apr), #2790 (shader). #1269 (media), #1339 (VRR), #1586 (unwind) and #1436 (imports) are now on main. Local image-table experiments are excluded; open #757 → #758 overlaps them, and #920 is closed without merging. Earlier combined integration reached menu/loading UI; these isolated branches have not been game-tested and gameplay is unverified.
Checklist
main; no duplicate implementation found beyond superseded fix(linux): resolve loader and APR failures exposed by HFW #1616