Skip to content

fix(libSceHttp): retain request-status callbacks with the guest ABI - #2788

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
tototomate123:fix/hfw-http-split
Oct 11, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
tototomate123:fix/hfw-http-split

Conversation

@tototomate123

@tototomate123 tototomate123 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

What

Split from #1616, following its review. Retain request-status callbacks and user data using the three-argument ABI from shadPS4; remove registrations when requests are deleted. The offline backend never dispatches callbacks. Unknown function info records the uncited invalid-id error 0x80431100 and incomplete hierarchy/deletion validation; the entry sits inside the section, away from recent insertions.

Tested

Linux x86-64, GCC 16.2.1, Release. guest_http passes, including callback registration, replacement, removal and invalid ids. MinGW C++20 syntax check passes; Windows runtime/CI has not been run locally. Conventions and whitespace checks pass on current main (5edae353).

Depends on

None for build. HFW integration also needs #2785 (relinker), #2786 (loader), #2787 (filesystem), #2789 (apr), #2790 (shader). #1269 (media), #1339 (VRR), #1586 (unwind) and #1436 (imports) are now on main. Local image-table experiments are excluded; open #757 → #758 overlaps them, and #920 is closed without merging. Earlier combined integration reached menu/loading UI; these isolated branches have not been game-tested and gameplay is unverified.

Checklist

  • Based on current main; no duplicate implementation found beyond superseded fix(linux): resolve loader and APR failures exposed by HFW #1616
  • One topic per PR
  • No code comments except technical debt
  • Unimplemented paths throw; offline HTTP limitations documented
  • No investigation notes, logs or images committed
  • No new third-party dependencies
  • Generic behavior; no title-specific dispatch
  • Depends on: none for build; HFW integration requirements listed above
  • AI-assisted: yes, Codex

@github-actions

Copy link
Copy Markdown

Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes.

@github-actions github-actions Bot closed this Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Progress report (ccb299c → 63d2911)

📈 System libraries: 85.84% (+0.03%, +1 implemented functions)

✅ 1 implemented
Library Name
libSceHttp sceHttpSetRequestStatusCallback

@oneandonlydean oneandonlydean removed the intake paused Closed while PR intake is limited to authors with at least 10 PRs merged into main label Oct 11, 2026
@oneandonlydean

Copy link
Copy Markdown
Collaborator

Reopened. There is a conflict in docs/dev/TechnicalDebt.md. Can you rebase?

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 11, 2026
@adriadam10

Copy link
Copy Markdown
Collaborator

Rebased onto current main (the only conflict was adjacency in docs/dev/TechnicalDebt.md, both lines kept). Checked guest_http plus the other tests in the touched directories on Linux/GCC; guest_http fails without the change. Merging.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 11, 2026
@Mouhand-Kaddo

Copy link
Copy Markdown
Contributor

Additional platform validation of standalone PR head 63d29116b478102d78256cfc9d9b0cdfe94ad1df (2026-10-11):

Windows: passed — Windows 11, WinLibs GCC 15.2.0 UCRT/POSIX/SEH r7; CMake 4.3.1 / Ninja; Release, BUILD_TESTING=ON.

1 checks, 0 failures, 0 CTest skips. Built the selected targets and dependencies; this is focused validation, not a full build or full-suite run.

Checks: guest_http.

Command after building: ctest --test-dir <build> --verbose --no-tests=error --timeout 30 -R "^guest_http$".

No title/gameplay validation. These results cover the standalone head, not a merge with current main.

@adriadam10
adriadam10 merged commit 683bb1c into boykopovar:main Oct 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants