Skip to content

fix(shader): evaluate signed minimum in runtime SRT expressions - #2790

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
tototomate123:fix/hfw-shader-split
Oct 11, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
tototomate123:fix/hfw-shader-split

Conversation

@tototomate123

@tototomate123 tototomate123 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

What

Split from #1616, following its review. Evaluate SMin32 in runtime SRT expressions with signed comparison, matching the existing IR/GPU lowering. No new GPU opcode is introduced.

Tested

Linux x86-64, GCC 16.2.1, Release. agc_shader_memory passes, including signed-min cases around zero, INT_MIN and INT_MAX. Conventions and whitespace checks pass on current main (5edae353).

Depends on

None for build. HFW integration also needs #2785 (relinker), #2786 (loader), #2787 (filesystem), #2788 (http), #2789 (apr). #1269 (media), #1339 (VRR), #1586 (unwind) and #1436 (imports) are now on main. Local image-table experiments are excluded; open #757 → #758 overlaps them, and #920 is closed without merging. Earlier combined integration reached menu/loading UI; these isolated branches have not been game-tested and gameplay is unverified.

Checklist

  • Based on current main; no duplicate implementation found beyond superseded fix(linux): resolve loader and APR failures exposed by HFW #1616
  • One topic per PR
  • No code comments except technical debt
  • Unimplemented paths throw; offline HTTP limitations documented
  • No investigation notes, logs or images committed
  • No new third-party dependencies
  • Generic behavior; no title-specific dispatch
  • Depends on: none for build; HFW integration requirements listed above
  • AI-assisted: yes, Codex

@github-actions

Copy link
Copy Markdown

Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes.

@github-actions github-actions Bot closed this Oct 10, 2026
@oneandonlydean oneandonlydean removed the intake paused Closed while PR intake is limited to authors with at least 10 PRs merged into main label Oct 11, 2026
@github-actions github-actions Bot added shader core/shader agc libSceAgc* labels Oct 11, 2026
@adriadam10

Copy link
Copy Markdown
Collaborator

Checked the build and agc_shader_memory on Linux (GCC) with the PR merged onto main, and the new test fails without the evaluator change. SMin32 now matches the signed lowering in EmitSMin32 and the constant folder; merging.

@adriadam10
adriadam10 merged commit 6968564 into boykopovar:main Oct 11, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agc libSceAgc* shader core/shader

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants