Repository navigation
feat(npwebapi2): implement sceNpWebApi2SetRequestTimeout - #2853
Conversation
|
Same as #2852: which title stops at |
|
Windows validation of the current head Windows 11 Pro 26220, WinLibs MinGW-w64 GCC 15.2.0 r7, Ninja, Release,
Validation run with Claude Code assistance. |
adriadam10
left a comment
There was a problem hiding this comment.
Thanks for the Windows run and the TechnicalDebt entry. Before this can go in:
- No title is named. @oneandonlydean asked which title stops at
sceNpWebApi2SetRequestTimeoutonmainand it is still unanswered. Please add the title ID and thenot implementedlog line where it stops; the import alone isn't enough. core/libs/prx/libSceNpWebApi2/Export.cpp:156: it succeeds for any request id. shadPS4 routes the call throughsetRequestTimeout(request_id, timeout)(np_web_api2.cpp:413), so please check what it validates and either follow it or say in the TechnicalDebt line why not.
Happy to look again once a title that reaches it is shown.
23aeebf to
621fd8d
Compare
|
No title I can run reaches
I'm converting this to a draft until a title stops at it. Then I'll post the title ID and the log line and mark it ready. Changed (rebased onto
Tested: Linux, GCC, Release, RX 9070 XT (RADV): full AI-assisted: yes (Claude Code) |
adriadam10
left a comment
There was a problem hiding this comment.
Thanks for the answer. Keeping this as a draft until a title actually stops at sceNpWebApi2SetRequestTimeout is right: please post the title ID and the not implemented log line when you have it, then mark it ready.
|
@alfalfa-star @adriadam10 Hi, i've got a title that stops with "sceNpWebApi2SetRequestTimeout not implemented" if it's useful to merge this PR, this happens on main Nvidia GPU, AMD CPU It's Pinball FX (PPSA08755), it loads and the main menu i think starts to appear but it stops after some frames and output this |
|
@alfalfa-star Pinball FX (PPSA08755) stops here on main, see leorossi2005's log above. Please rebase and mark it ready. |
The timeout setter takes (request id, timeout) and succeeds without checking the request, like the other request setters: no request reaches a service, so no timeout can expire. PPSA14632 imports it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…quest id shadPS4 looks the request up through its library and user contexts and returns the matching NOT_FOUND error. This library keeps no request table: CreateRequest hands out counter values and the other request calls accept any id, so the checks wait for request tracking across all of them. The entry moves to Silent stubs, as main's conventions check now requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
19891c7 to
70389c0
Compare
|
@oneandonlydean rebased onto @adriadam10, the earlier change requests were about not having a title; Pinball FX is that title now. Thanks @leorossi2005 for the log. |
|
Thanks for the rebase and the title. The full build is green on this head; before it goes in it needs one run by someone other than the author: Pinball FX (PPSA08755) on current |
Met on 70389c0: the description now names Pinball FX (PPSA08755) with the log line, which was the open point.
|
Checked: |
Why
Pinball FX (PPSA08755) stops on
main7a0c838 while its main menu appears (log from @leorossi2005):What
Implements
sceNpWebApi2SetRequestTimeout(request id, timeout), which still calledNotImplemented_nid_no_patch.Like the other request calls in this library, it succeeds without checking the request id. shadPS4 returns
LIB_CONTEXT_NOT_FOUND,USER_CONTEXT_NOT_FOUNDorREQUEST_NOT_FOUNDfor unknown ids, but this library keeps no request table (CreateRequesthands out counter values;AbortRequest,AddHttpRequestHeaderandDeleteRequestaccept any id), so those checks wait for request tracking across all of them. No request reaches a service (sceNpWebApi2SendRequestfails withUNAVAILABLEat once), so no timeout can expire. The signature follows shadPS4.docs/dev/debt/libSceNpWebApi2.mdlists it under Silent stubs with that reason.sceNpWebApi2AddWebTraceTag, came with PPSA33016.guest_np_web_api2creates a request, sets its timeout and deletes it; it aborts withmain'sExport.cpp.Tested
Linux (Arch, GCC 15), Release build of this branch rebased onto
maine2cd213:ctest: 1099 of 1100 pass.agc_driver_tessellationsegfaults on plainmainon this machine as well.tools/check_conventions.py --base upstream/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code