Skip to content

feat(webbrowserdialog): implement predetermined content and cookie calls - #2854

Closed
alfalfa-star wants to merge 3 commits into
boykopovar:mainfrom
alfalfa-star:feat/webbrowserdialog-cookies
Closed

alfalfa-star wants to merge 3 commits into
boykopovar:mainfrom
alfalfa-star:feat/webbrowserdialog-cookies

Conversation

@alfalfa-star

@alfalfa-star alfalfa-star commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

What

Implements three libSceWebBrowserDialog exports that still called NotImplemented_nid_no_patch:

  • sceWebBrowserDialogOpenForPredeterminedContent(param, predetermined) finishes at once, like sceWebBrowserDialogOpen, with the same not-initialized, busy and null-argument checks. It does not read the allow-list.
  • sceWebBrowserDialogSetCookie(param) and sceWebBrowserDialogResetCookie(param) succeed for a non-null block. The dialog loads no page, so there is no cookie store: the cookie is discarded and there is nothing to reset. A null block returns ARG_NULL.

The signatures follow SharpProspero. The error for a null allow-list and the console's size checks on the blocks are unknown. The signatures and unknowns are under "Unknown function info" in TechnicalDebt, and the no-page, no-cookie-store model is under "Functional". PPSA14632 and PPSA12544 import them.

Tested

Linux (Arch, GCC), Release build, on main 57f96fd:

  • guest_web_browser_dialog: checks the not-initialized and both null-argument errors, the finished state after opening, and both cookie calls with a block and with null. It aborts without this change (exit 134).
  • Full ctest: 698/698 passed (4 skipped for lack of a display).
  • tools/check_conventions.py --base upstream/main passed.

Checklist

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Progress report (dbc3b06 → f661e87)

📈 System libraries: 85.53% (+0.09%, +3 implemented functions)

✅ 3 implemented
Library Name
libSceWebBrowserDialog sceWebBrowserDialogOpenForPredeterminedContent
libSceWebBrowserDialog sceWebBrowserDialogResetCookie
libSceWebBrowserDialog sceWebBrowserDialogSetCookie

@github-actions github-actions Bot mentioned this pull request Oct 10, 2026
9 tasks done
@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 10, 2026
@oneandonlydean

Copy link
Copy Markdown
Collaborator

Same as #2852: please add the log line where PPSA14632 or PPSA12544 stops at one of these on main.

@screamm

screamm commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Windows validation of the current head 31822fde on main 262c0316.

The branch no longer merges cleanly: git merge main conflicts in docs/dev/TechnicalDebt.md (both sides append to the same place). The code and test files merge without conflict, so I built and tested that merged tree with the documentation conflict left unresolved.

Windows 11 Pro 26220, WinLibs MinGW-w64 GCC 15.2.0 r7, Ninja, Release, BUILD_TESTING=ON, full build including the libs target:

  • guest_web_browser_dialog passes 3/3 (--repeat until-fail:3).
  • ctest -j8 -E "^agc_|video_out" passes 388/388.
  • With main's libSceWebBrowserDialog/Export.cpp and this PR's test, guest_web_browser_dialog fails, so the coverage detects the previous behaviour.

Validation run with Claude Code assistance.

@adriadam10 adriadam10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Windows-confirmed test. Two things before this can land:

  • @oneandonlydean asked above for the log line where PPSA14632 or PPSA12544 stops at one of these exports on main. The PR only says the title imports them; an import alone doesn't show a title calls them. Please add the not implemented line (which export, which title) so the success stubs unblock something concrete.
  • The branch conflicts with main in docs/dev/TechnicalDebt.md (the line shared with #2852/#2853). Please rebase once the log line is added.

Signatures match SharpProspero's WebBrowserDialog.cs, and the test fails on main, so no change needed there.

alfalfa-star and others added 3 commits October 11, 2026 11:41
sceWebBrowserDialogOpenForPredeterminedContent finishes at once like
sceWebBrowserDialogOpen. The dialog loads no page, so there is no cookie
store: sceWebBrowserDialogSetCookie and sceWebBrowserDialogResetCookie
succeed for a non-null block. PPSA14632 and PPSA12544 import them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…minating

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alfalfa-star
alfalfa-star force-pushed the feat/webbrowserdialog-cookies branch from 31822fd to f661e87 Compare October 11, 2026 09:42
@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 11, 2026
@alfalfa-star

Copy link
Copy Markdown
Contributor Author

No title I can run reaches these exports on current main (90c152e):

I'm converting this to a draft until a title stops at it. Then I'll post the title ID and the log line and mark it ready.

Rebased onto main. Both TechnicalDebt conflicts are resolved, including the reworded PPSA12544 line.

Tested: Linux, GCC, Release, RX 9070 XT (RADV): full ctest 813/813 (4 video_out_flip_* skipped) on main 90c152e merged with this branch; tools/check_conventions.py passes.

AI-assisted: yes (Claude Code)

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs needs rebase Conflicts with main, rebase needed prx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants