Repository navigation
feat(webbrowserdialog): implement predetermined content and cookie calls - #2854
alfalfa-star wants to merge 3 commits into
Conversation
Progress report (dbc3b06 → f661e87)📈 System libraries: 85.53% (+0.09%, +3 implemented functions) ✅ 3 implemented
|
|
Same as #2852: please add the log line where PPSA14632 or PPSA12544 stops at one of these on main. |
|
Windows validation of the current head The branch no longer merges cleanly: Windows 11 Pro 26220, WinLibs MinGW-w64 GCC 15.2.0 r7, Ninja, Release,
Validation run with Claude Code assistance. |
adriadam10
left a comment
There was a problem hiding this comment.
Thanks for the Windows-confirmed test. Two things before this can land:
- @oneandonlydean asked above for the log line where PPSA14632 or PPSA12544 stops at one of these exports on
main. The PR only says the title imports them; an import alone doesn't show a title calls them. Please add thenot implementedline (which export, which title) so the success stubs unblock something concrete. - The branch conflicts with
mainindocs/dev/TechnicalDebt.md(the line shared with #2852/#2853). Please rebase once the log line is added.
Signatures match SharpProspero's WebBrowserDialog.cs, and the test fails on main, so no change needed there.
sceWebBrowserDialogOpenForPredeterminedContent finishes at once like sceWebBrowserDialogOpen. The dialog loads no page, so there is no cookie store: sceWebBrowserDialogSetCookie and sceWebBrowserDialogResetCookie succeed for a non-null block. PPSA14632 and PPSA12544 import them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…minating Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
31822fd to
f661e87
Compare
|
No title I can run reaches these exports on current
I'm converting this to a draft until a title stops at it. Then I'll post the title ID and the log line and mark it ready. Rebased onto Tested: Linux, GCC, Release, RX 9070 XT (RADV): full AI-assisted: yes (Claude Code) |
|
Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line. |
What
Implements three libSceWebBrowserDialog exports that still called
NotImplemented_nid_no_patch:sceWebBrowserDialogOpenForPredeterminedContent(param, predetermined)finishes at once, likesceWebBrowserDialogOpen, with the same not-initialized, busy and null-argument checks. It does not read the allow-list.sceWebBrowserDialogSetCookie(param)andsceWebBrowserDialogResetCookie(param)succeed for a non-null block. The dialog loads no page, so there is no cookie store: the cookie is discarded and there is nothing to reset. A null block returnsARG_NULL.The signatures follow SharpProspero. The error for a null allow-list and the console's size checks on the blocks are unknown. The signatures and unknowns are under "Unknown function info" in TechnicalDebt, and the no-page, no-cookie-store model is under "Functional". PPSA14632 and PPSA12544 import them.
Tested
Linux (Arch, GCC), Release build, on
main57f96fd:guest_web_browser_dialog: checks the not-initialized and both null-argument errors, the finished state after opening, and both cookie calls with a block and with null. It aborts without this change (exit 134).ctest: 698/698 passed (4 skipped for lack of a display).tools/check_conventions.py --base upstream/mainpassed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code