Repository navigation
feat(libSceCesCs): add sceCesRefersUcsProfileCp1251 and sceCesMbcsUcsContextInit - #3824
Merged
Merged
Conversation
…ContextInit PPSA15246 (Teardown) imports both from the module-named libSceCesCs-module and stops at the loader without them. Cp1251 joins Cp1252 in sceCesSbcToUtf8 and sceCesUtf8ToSbc; the context initializer succeeds without storing anything because its layout is unknown (listed in TechnicalDebt.md). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Progress report (bab7b32 → 50ca599)📈 System libraries: 86.48% (+0.01%, +2 implemented functions) ✅ 2 implemented
⚪ 1 behaviourally empty (constant return or throw)
|
This was referenced Oct 11, 2026
adriadam10
requested changes
Oct 11, 2026
adriadam10
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, the Cp1251 table and the profile handling check out (all 128 entries match the Windows-1251 codec; guest_ces passes on a Linux build and fails to link without the change). Two things to fix:
core/libs/prx/libSceCesCs-module/CMakeLists.txt: the only-moduletargets onmainarelibSceFont-moduleandlibSceFontFt-module, which exist because a title loads the library under that name. Please show that PPSA15246 (or another title) loadslibSceCesCs-module, with a test that uses the target, or drop it from this PR. As is, it compiles the same exports a second time and nothing builds or tests it (EXCLUDE_FROM_ALL).docs/dev/TechnicalDebt.md:47: the new line is the last one of "Silent stubs", where other open PRs append (#2850 already touches the neighbouring line, so this will conflict). Please place it a few lines away from the end of the section.
…lDebt line Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Thanks, both points addressed in the new commit on this branch:
Tested: AI-assisted (Claude Code). |
This was referenced Oct 11, 2026
adriadam10
approved these changes
Oct 11, 2026
adriadam10
left a comment
Collaborator
There was a problem hiding this comment.
Checked the Cp1251 table (128 entries), both profiles in sceCesSbcToUtf8/sceCesUtf8ToSbc, guest_ces (passes; fails to link without the change) and the TechnicalDebt placement; both review points are addressed. Merging.
# Conflicts: # docs/dev/TechnicalDebt.md
This was referenced Oct 12, 2026
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
sceCesRefersUcsProfileCp1251andsceCesMbcsUcsContextInittolibSceCesCs, which PPSA15246 imports.sceCesRefersUcsProfileCp1251returns a profile thatsceCesSbcToUtf8andsceCesUtf8ToSbcaccept next to the existing Cp1252 one, with the Windows-1251 table of Microsoft's bestfit1251.txt (byte 0x98, unassigned there, maps to U+0098 like the unassigned Cp1252 bytes; the console behavior for that byte is not verified).sceCesMbcsUcsContextInit(context, profile)returns the invalid-parameter error for a null context and success otherwise without writing to the context: its layout and size are unknown. The signature follows the Orbital IDA type database. Listed indocs/dev/TechnicalDebt.md.guest_ces_testsgets a Cp1251 round-trip case.Tested
Windows,
maina11c8f7 plus this branch:python tools/check_conventions.py --base upstream/mainpasses;ctest -R guest_cespasses. Not tested on Linux and not run against PPSA15246 with this branch; no conversion through an initialized context exists.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository