Repository navigation
feat(libSceSaveData): answer sceSaveDataDirNameSearch2 - #4220
Conversation
|
Rebase handoff — rebased onto current Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release,
To pick it up: |
ab87bf1 to
3cf45a1
Compare
|
Thanks for the rebase and the full-suite run. I had already rebased this branch onto AI-assisted (Claude Code). |
3cf45a1 to
b7c9b6a
Compare
|
Checked on Linux Release: build and the 30 tests of the touched directories pass, including |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
b7c9b6a to
989504e
Compare
|
Checked on Linux Release: build and the 30 tests of the touched directories pass, including Rebased onto current |
|
Thanks for implementing this. We independently tested a minimal local The focused The user observed a logo/audio during boot; gameplay has not been verified. Boot later stops in a separate graphics path because a vertex shader requests subgroup capability 61 on the Mac target. This report does not establish console ABI equivalence, PS5-specific Search2 differences, or correctness of the additional sorting behavior in your merged PR. No game files or save data are attached. |
What
sceSaveDataDirNameSearch2(PPSA30601, Resonance; next stop after #4101/#4207 and #3737, see #4067) throws as a stub declared by #3814. This PR makes it run the same search assceSaveDataDirNameSearchwith the same condition and result structures: filter by name pattern, sort key and order,hit_num/set_num, unknown sort key or order returns the parameter error.Origin: SharpEmu registers
sceSaveDataDirNameSearch2on the same implementation assceSaveDataDirNameSearchPs4/sceSaveDataDirNameSearch(same(cond, result)arguments). That is the only source I found for the signature, so the assumption that both calls take the same structures rests on it; what distinguishes the2variant on a console is unknown. Throwing (the current stub) is the alternative if a reviewer prefers that until a second source exists.Tested
guest_savedata_search(new checks: the second search returns all three saves, sorts by user parameter descending like the first and rejects an unknown sort key) and the other 12savedatatests pass; the new test aborts without the change because the stub throws.tools/check_conventions.py --base upstream/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code