Repository navigation
fix(libSceAmpr): export sceAmprAmmSetPageTablePoolOccupancyNotificationThreshold - #4251
Merged
oneandonlydean merged 1 commit intoOct 12, 2026
Conversation
This was referenced Oct 12, 2026
…onThreshold Resolves NID touqMEt6qXQ, the last import Trails in the Sky 2nd Chapter (PPSA35169) is left missing on libSceAmpr.prx once the libkernel pair in boykopovar#4214 is recorded. No reference describes the function's contract, so it throws via the project's NotImplemented_nid_no_patch pattern rather than guessing a result that a caller would act on. sceAmprAmmGetUsageStatsData (KqiWXLgCVe0) is deliberately not included: boykopovar#3814 exports it and boykopovar#4207 answers it from a cited layout. See issue boykopovar#4214.
Dextroid17
force-pushed
the
fix/libampr-usage-stats-stubs
branch
from
October 12, 2026 03:24
49ee6c1 to
ef3b121
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exports
sceAmprAmmSetPageTablePoolOccupancyNotificationThreshold(touqMEt6qXQ) — once the twolibkernelrecorders of #4214 (#4244) and the sibling export below are landed, this is the last import Trails in the Sky 2nd Chapter (PPSA35169, 01.003.000) is left missing onlibSceAmpr.prx. The name hashes to exactly that NID (tools/nid_names.py), so the plain export binds it, and the built library carries it:nm -DlistssceAmprAmmSetPageTablePoolOccupancyNotificationThresholdin the producedlibSceAmpr.prx.Nothing in this tree implements the call, and the only counterpart elsewhere is itself a placeholder. KytyPS5's
libAmpr.cppbinds the same NID toAmmSetPageTablePoolOccupancyNotificationThreshold(uint32_t), whose whole body isPRINT_NAME(); return OK;— it never reads the value it is handed. Porting that would ship exactly the success-that-ignores-its-input this project refuses, so the export throws instead:NotImplemented_nid_no_patch, the documented state for an unimplemented export inCONTRIBUTING.md. The declared arity follows the existing stubs in this tree, which take no parameters and throw before any argument is read.The sibling import of the same set,
sceAmprAmmGetUsageStatsData(KqiWXLgCVe0), is deliberately not in this PR: three other open PRs already carry it — #3814 and #4220 as throwing stubs, #4207 as an implementation from a cited layout. A copy here would only put a second PR on the same export.Tested
Linux (CachyOS), GCC 16.2.1, Release, full build of
main+ this branch:guest_ampr_tests(registered as ctestguest_ampr_markers) passes, andnm -Don the producedlibSceAmpr.prxlists the export. Onmain(d146ec1b6) neither this name norsceAmprAmmGetUsageStatsDataexists anywhere undercore/, so no library built frommaincan resolve either NID.libkernelrecorders (feat(libkernel): record APR memory protection and remap commands #4244), thesceAmprAmmGetUsageStatsDataexport (fix(exports): export the calls PPSA30601 imports #3814 / feat(libSceAmpr): answer sceAmprAmmGetUsageStatsData #4207) and this one: the title clears the wall in libkernel: sceKernelWriteModifyMtypeProtectCommand and sceKernelWriteRemapIntoPrtCommand are not exported (Trails in the Sky 2nd Chapter, PPSA35169) #4214 and gets much further than before, creating its Vulkan device and swapchain, touching save data and running 16 game threads (measured). It then stops on an unrelated NGS2 audio wall, filed as libSceNgs2.native: custom rack module id 0x20 (PitchShift) is not implemented (Trails in the Sky 2nd Chapter, PPSA35169) #4246. Only the export set moves the title, which is why this is one export of that set and not a fix on its own.tools/check_conventions.pypasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)