Skip to content

docs(contributing): ask GPU changes to name the GPUs their tests ran on - #4459

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
LeandroLP23:docs/contributing-gpus-tested
Oct 13, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
LeandroLP23:docs/contributing-gpus-tested

Conversation

@LeandroLP23

Copy link
Copy Markdown
Contributor

What

Closes #4458. Adds a GPUs tested: checklist line to the pull request template and a line in CONTRIBUTING that asks AGC, shader recompiler and VideoOut changes to name each GPU their GPU tests ran on (vendor, model, driver, OS). CI runs those tests only on lavapipe, so the checklist is where a reviewer sees whether only one vendor was covered. #4152 → #4435 is the case that prompted it; #4345 discusses the CI side.

The line is not enforced by check_conventions.py, like Unblocks:.

Tested

Documentation only. python tools/check_conventions.py --base origin/main and python -m unittest discover -s tools/tests pass.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes (Claude Code)

@LeandroLP23

Copy link
Copy Markdown
Contributor Author

@AlxcBTW #4590 adds its line to CONTRIBUTING.md at the same place as this PR's line, so whichever merges second hits a one-line conflict. Neither depends on the other, and both lines stay. If #4590 goes in first, I'll rebase this one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LeandroLP23
LeandroLP23 force-pushed the docs/contributing-gpus-tested branch from 8617e80 to fa889c0 Compare October 13, 2026 05:46
@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 13, 2026
@adriadam10

Copy link
Copy Markdown
Collaborator

Checked the diff against the template and CONTRIBUTING on current main (the #4590 line is already in, no conflict); check_conventions.py doesn't require the new line and Conventions is green on this head. Merging.

@adriadam10
adriadam10 merged commit ab1755c into boykopovar:main Oct 13, 2026
7 checks passed
@LeandroLP23
LeandroLP23 deleted the docs/contributing-gpus-tested branch October 13, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci .github docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull requests that change GPU code don't say which GPUs their tests ran on, and a driver-specific regression reached main (#4435)

2 participants