Repository navigation
docs(contributing): ask GPU changes to name the GPUs their tests ran on - #4459
Merged
adriadam10 merged 1 commit intoOct 13, 2026
Merged
Conversation
10 tasks done
Contributor
Author
6 tasks done
11 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LeandroLP23
force-pushed
the
docs/contributing-gpus-tested
branch
from
October 13, 2026 05:46
8617e80 to
fa889c0
Compare
Collaborator
|
Checked the diff against the template and CONTRIBUTING on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #4458. Adds a
GPUs tested:checklist line to the pull request template and a line in CONTRIBUTING that asks AGC, shader recompiler and VideoOut changes to name each GPU their GPU tests ran on (vendor, model, driver, OS). CI runs those tests only on lavapipe, so the checklist is where a reviewer sees whether only one vendor was covered. #4152 → #4435 is the case that prompted it; #4345 discusses the CI side.The line is not enforced by
check_conventions.py, likeUnblocks:.Tested
Documentation only.
python tools/check_conventions.py --base origin/mainandpython -m unittest discover -s tools/testspass.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)