Skip to content

fix(ci): skip absent overlap reports - #4534

Closed
MiniRML wants to merge 2 commits into
boykopovar:mainfrom
MiniRML:fix/ci-empty-overlap-reports
Closed

MiniRML wants to merge 2 commits into
boykopovar:mainfrom
MiniRML:fix/ci-empty-overlap-reports

Conversation

@MiniRML

@MiniRML MiniRML commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

What

When the overlap report directory contains no Markdown reports, Bash leaves *.md unexpanded. The workflow then requests issues/*/comments, causing a 404 and a failed run on forks with no open PRs. Skip entries that are not files before accessing GitHub. Existing reports still follow the same comment update path.

Tested

Windows 11, Python 3.13 and Git for Windows Bash. The new workflow regression executes the actual comment-processing script with local GitHub/jq substitutes: empty and non-Markdown-only directories fail on the base, then pass with the fix; a real report still reads and creates its comment. No network calls are made by the regression.

  • Focused test_pr_overlap.py: 7 tests passed.
  • Complete tools suite: 201 tests, 199 passed and 2 symlink tests skipped because creating their links is unavailable on this Windows setup.
  • Conventions and whitespace checks passed. Merge simulation against ci: log workflow results and write GitHub job summaries #988 was clean; it adds reporting rather than addressing the empty glob.
  • No title or PS5 hardware needed: this fixes the workflow's handling of an empty report directory. No emulator runtime behavior changed.

Checklist

  • Based on current main; no other open PR implements the same fix
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw; no runtime stubs changed
  • No notes, investigation files or images added to the repository
  • New third-party code is a submodule built from source; none added
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • AI-assisted: yes

@github-actions github-actions Bot added the ci .github label Oct 12, 2026
@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 12, 2026
@xXPBSXx

xXPBSXx commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Windows test note: this branch (base 2a5eca11c) no longer merges onto current main 0f2683cb7; git merge-tree reports a conflict in .github/workflows/pr-overlap.yml, so I could not run its checks on a merged tree. A rebase onto current main would allow a Windows run.

AI-assisted (Claude Code).

@adriadam10

Copy link
Copy Markdown
Collaborator

Closing as obsolete: current main already has shopt -s nullglob before the for file in "$out"/*.md loop in .github/workflows/pr-overlap.yml, so an empty report directory no longer iterates and no issues/*/comments request is made. The branch also conflicts with that workflow now, and the new test extracts the script from the old version of it.

Feel free to reopen rebased if you can show a case that still fails on current main.

@adriadam10 adriadam10 closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci .github needs rebase Conflicts with main, rebase needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants