Repository navigation
Conversation
|
Independent Windows validation of the current PR head
This was a targeted test build only; no full native build or title runtime was run. No changes were made to the PR branch. AI-assisted verification: OpenAI Codex. The PR author remains responsible for the submitted implementation. |
11 tasks done
This was referenced Oct 13, 2026
10 tasks done
Collaborator
|
Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line. |
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5095
What
Carry the three commits from David Samir's ready fix branch, preserving their original commit authorship. On Windows, opening an existing file with
O_RDONLY | O_TRUNCcurrently passesGENERIC_READwithTRUNCATE_EXISTING, whichCreateFileWrejects. For this flag combination, open with read/write access so truncation succeeds, then duplicate the handle with read-only access and close the original. Other flag combinations are unchanged.Add
TestReadOnlyTruncatingOpentoguest_filesystemto verify truncation through another open descriptor, read-only behavior of the returned descriptor, missing-file and directory errors, andEACCESfor a read-only file. Record the remaining Windows host sharing limitation in technical debt.Tested
guest_filesystem_tests, and ranguest_filesystemthree times; all three passed.tools/check_conventions.py --base upstream/mainandgit diff --checkpass.ctest --parallel 4passed 1051/1051. That Windows run predates this rebase and was not repeated here.Checklist
main; no other open PR implements the same functions