Repository navigation
Conversation
FreeBSD's raise goes through thr_kill, which treats signal 0 as a validity check and returns 0; the guest export rejected it with EINVAL. (cherry picked from commit d1f6145)
11 tasks done
Contributor
|
Windows 10 (19045), MinGW-w64 GCC 15.2.0, Release,
AI-assisted (Claude Code). |
Collaborator
|
Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line. |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Carry Hussein Kadhim's
raise(0)fix onto currentmain, preserving his original commit author. Signal zero is now treated as a thread-validity check: it returns 0 without touching dispositions, blocked/pending state, handlers orerrno. Other out-of-range values still returnEINVAL.Tested
guest_signal_tests,guest_kill_testsandguest_sigtimedwait_tests.guest_signals,guest_killandguest_sigtimedwaitpassed (3/3).python3 tools/check_conventions.py --base upstream/mainpassed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)raiseimplementation; this fix should layer on its per-thread signal behavior)