Skip to content

fix(libkernel): accept signal 0 in raise - #5261

Closed
MarcZX10 wants to merge 1 commit into
boykopovar:mainfrom
MarcZX10:fix/signals-raise-zero-5257
Closed

MarcZX10 wants to merge 1 commit into
boykopovar:mainfrom
MarcZX10:fix/signals-raise-zero-5257

Conversation

@MarcZX10

Copy link
Copy Markdown
Contributor

What

Carry Hussein Kadhim's raise(0) fix onto current main, preserving his original commit author. Signal zero is now treated as a thread-validity check: it returns 0 without touching dispositions, blocked/pending state, handlers or errno. Other out-of-range values still return EINVAL.

Tested

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: fix(libkernel): keep the signal mask per thread #3986 (it changes the same raise implementation; this fix should layer on its per-thread signal behavior)
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

FreeBSD's raise goes through thr_kill, which treats signal 0 as a validity check and returns 0; the guest export rejected it with EINVAL.

(cherry picked from commit d1f6145)
@xXPBSXx

xXPBSXx commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Windows 10 (19045), MinGW-w64 GCC 15.2.0, Release, -j4: head 57655db38 of this PR merged onto main d7bb2fee3 (clean merge, 2 files).

  • guest_signals passes (1.55 s, ctest).
  • With core/libs/prx/libkernel/System/src/Signals.cpp taken back to main and the PR's new test lines kept, guest_signals fails (exit code 0xc0000409).
  • Not run: Linux, a console, a title.

AI-assisted (Claude Code).

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants