Skip to content

fix(libkernel): accept signal 0 in raise #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcZX10 wants to merge 1 commit into from
Closed

fix(libkernel): accept signal 0 in raise #5261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/libs/prx/libkernel/System/src/Signals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ int APS5_VABI sigaction_nid_postfix(int guest, const GuestSigaction* action, Gue
return 0;
}
int APS5_VABI raise_nid_postfix(int guest) {
if (guest < 1 || guest > MaxSignal) { *__error_nid_postfix() = 22; return -1; }
if (guest < 0 || guest > MaxSignal) { *__error_nid_postfix() = 22; return -1; }
if (guest == 0) return 0;
const GuestSigaction action = Disposition(guest);
if (action.handler > 1 && !Delivered(action)) throw std::runtime_error("raise: SA_SIGINFO handlers are not delivered");
if (SignalBlocked(guest)) {
Expand Down
6 changes: 6 additions & 0 deletions core/libs/tests/GuestSignals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ int main() {
Require(raise_nid_postfix(15) == 0 && received == 0);
Require(signal_nid_postfix(15, nullptr) == ignore);
Require(raise_nid_postfix(100) == -1 && *__error_nid_postfix() == 22);
*__error_nid_postfix() = 12345;
Require(raise_nid_postfix(0) == 0 && *__error_nid_postfix() == 12345 && received == 0);
for (int outOfRange : {-1, 129}) {
*__error_nid_postfix() = 0;
Require(raise_nid_postfix(outOfRange) == -1 && *__error_nid_postfix() == 22);
}
GuestSignalSet blocked{{0x20, 0, 0, 0}};
GuestSignalSet previous{{}};
Require(sigprocmask_nid_postfix(3, &blocked, &previous) == 0);
Expand Down
Loading