Skip to content

feat(libSceNet): return success from ShowIfconfig and ShowNetstat - #5928

Merged
adriadam10 merged 3 commits into
boykopovar:mainfrom
Kurenaiiiii:feat/libSceNet-show
Oct 16, 2026
Merged

adriadam10 merged 3 commits into
boykopovar:mainfrom
Kurenaiiiii:feat/libSceNet-show

Conversation

@Kurenaiiiii

Copy link
Copy Markdown
Contributor

What

sceNetShowIfconfig and sceNetShowNetstat return success instead of throwing. The () signatures and the success return follow shadPS4, which stubs both the same way. Recorded as silent stubs in the libSceNet debt file. This leaves no throwing stub in the library. Test asserts both returns in CheckNetstat.

Tested

Not run here (no full toolchain in this container). Export.cpp parses clean, conventions check passes. Left guest_sce_net to CI.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: PPSA01530 Exports for PPSA01530, PPSA23827 and PPSA13356 imports #3177 (loader needs the ShowIfconfig export; PPSA11386 imports ShowNetstat)
  • GPUs tested: n/a
  • AI-assisted: yes

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Progress report (c842491 → 8c6f08b)

📈 System libraries: 88.88% (+0.05%, +2 implemented functions)

✅ 2 implemented
Library Name
libSceNet sceNetShowIfconfig
libSceNet sceNetShowNetstat
⚪ 2 behaviourally empty (constant return or throw)
Library Name
libSceNet sceNetShowIfconfig
libSceNet sceNetShowNetstat

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
PR 5676 core/libs/tests/GuestPPSA01530Exports.cpp L8-9, L20-21
docs/dev/debt/libSceNet.md L5
PR 6281 docs/dev/debt/libScePad.md L11
PR 6286 docs/dev/debt/libSceNet.md L2, L7
PR 6600 docs/dev/debt/libScePad.md L11
PR 6603 docs/dev/debt/libSceNet.md L7
PR 6838 docs/dev/debt/libSceUlt.md L7

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 5038 docs/dev/debt/libScePad.md
PR 6044 core/libs/tests/GuestPPSA01530Exports.cpp
core/libs/tests/GuestSceNet.cpp
PR 6447 core/libs/prx/libSceNet/Export.cpp
docs/dev/debt/libSceNet.md
docs/dev/debt/libScePad.md

@jotitadev jotitadev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux run: guest_sce_net passes, but the PR breaks the existing guest_ppsa01530_exports test.

Machine: Ubuntu 26.04, Intel i7-8700, GCC 15.2, Release, full build (-DBUILD_TESTING=ON), non-GPU tests. Head fca8c3c5e merged onto main 03c4cb5e7 (clean merge).

  • guest_sce_net passes with the PR. With only the test applied (Export.cpp from main) it aborts with sceNetShowNetstat not implemented, so the new assertions cover the change.
  • Full non-GPU suite: 3 failures out of 670. file_writer_binary and file_writer_text also fail on plain main on this machine. The new one is guest_ppsa01530_exports:
    sceNetShowIfconfig returned instead of reporting that it is not implemented
    
    core/libs/tests/GuestPPSA01530Exports.cpp asserts that sceNetShowIfconfig still throws not implemented. It passes on main. The PR has to drop sceNetShowIfconfig from that test's exports[] table (and its declaration), keeping scePadUnknown_n3kSX62fgNo. The full CI did not run on this PR (linux is skipped), so it has not caught this yet.

Written with AI assistance (Claude Code). I ran the builds and tests above on my machine.

@adriadam10 adriadam10 self-assigned this Oct 16, 2026
@adriadam10

Copy link
Copy Markdown
Collaborator

Checked on a local Linux build merged onto current main: guest_sce_net passes, and the only failure was guest_ppsa01530_exports (found by @jotitadev as well), which still asserted that sceNetShowIfconfig throws.

Added on top of your branch:

  • core/libs/tests/GuestPPSA01530Exports.cpp: dropped sceNetShowIfconfig from the not-implemented table and its declaration, keeping scePadUnknown_n3kSX62fgNo.

Scoped ctest (37 tests) is green after that; merging once the full build is green.

@adriadam10
adriadam10 merged commit ac0427f into boykopovar:main Oct 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants