Repository navigation
feat(libSceNet): return success from ShowIfconfig and ShowNetstat - #5928
Conversation
Progress report (c842491 → 8c6f08b)📈 System libraries: 88.88% (+0.05%, +2 implemented functions) ✅ 2 implemented
⚪ 2 behaviourally empty (constant return or throw)
|
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
f1288f5 to
f03b1b5
Compare
jotitadev
left a comment
There was a problem hiding this comment.
Linux run: guest_sce_net passes, but the PR breaks the existing guest_ppsa01530_exports test.
Machine: Ubuntu 26.04, Intel i7-8700, GCC 15.2, Release, full build (-DBUILD_TESTING=ON), non-GPU tests. Head fca8c3c5e merged onto main 03c4cb5e7 (clean merge).
guest_sce_netpasses with the PR. With only the test applied (Export.cpp from main) it aborts withsceNetShowNetstat not implemented, so the new assertions cover the change.- Full non-GPU suite: 3 failures out of 670.
file_writer_binaryandfile_writer_textalso fail on plain main on this machine. The new one isguest_ppsa01530_exports:sceNetShowIfconfig returned instead of reporting that it is not implementedcore/libs/tests/GuestPPSA01530Exports.cppasserts thatsceNetShowIfconfigstill throwsnot implemented. It passes on main. The PR has to dropsceNetShowIfconfigfrom that test'sexports[]table (and its declaration), keepingscePadUnknown_n3kSX62fgNo. The full CI did not run on this PR (linuxis skipped), so it has not caught this yet.
Written with AI assistance (Claude Code). I ran the builds and tests above on my machine.
|
Checked on a local Linux build merged onto current main: Added on top of your branch:
Scoped ctest (37 tests) is green after that; merging once the full build is green. |
fca8c3c to
8c6f08b
Compare
What
sceNetShowIfconfig and sceNetShowNetstat return success instead of throwing. The () signatures and the success return follow shadPS4, which stubs both the same way. Recorded as silent stubs in the libSceNet debt file. This leaves no throwing stub in the library. Test asserts both returns in CheckNetstat.
Tested
Not run here (no full toolchain in this container). Export.cpp parses clean, conventions check passes. Left guest_sce_net to CI.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)