Skip to content

fix(libSceNet): silent stub for sceNetShowNetstat - #6286

Closed
mazen320 wants to merge 1 commit into
boykopovar:mainfrom
mazen320:fix/net-show-netstat-silent-stub
Closed

mazen320 wants to merge 1 commit into
boykopovar:mainfrom
mazen320:fix/net-show-netstat-silent-stub

Conversation

@mazen320

@mazen320 mazen320 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What

sceNetShowNetstat no longer calls NotImplemented_nid_no_patch. It returns 0 with no netstat dump.

PPSA11386 imports it with an unknown signature. Debt moved into Silent stubs. New guest_net_show_netstat covers the return.

Silent stub evidence (CONTRIBUTING)

A silent stub is allowed only when it unblocks a title and only affects the UI (or is otherwise safe to ignore). Load-stop alone is not enough (see #6274).

Check Evidence
Unblocks a title PPSA11386 fails to resolve the import without this export
Safe to ignore / not runtime control Name is a Show* diagnostic dump; the stub produces no host netstat output and does not change sockets or routing
Not exercised at start-up Technical debt records that PPSA11386 imports it and does not call it during start-up (libSceNet.md)

This is the same class of exception as an unused import: returning 0 does not skip measured net behaviour on the observed path. If reviewers want a stricter “dialog/UI library only” reading, this PR can be withdrawn.

Tested

Windows 11. python tools/check_conventions.py --base upstream/main passed. Built the original libc, libkernel, libSceNet and test targets from this PR head in a separate CMake harness. ctest --output-on-failure -R ^guest_net_show_netstat$ passed on 2026-10-15. This is local targeted validation; upstream full builds remain skipped.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: PPSA11386 (ShowNetstat import)
  • GPUs tested: n/a
  • AI-assisted: yes

PPSA11386 imports the unknown-signature export; return 0 with no netstat dump
and list it under Silent stubs.
@mazen320

Copy link
Copy Markdown
Contributor Author

Overlap (#6285)

Bot may flag docs/dev/debt/libSceNet.md / CMakeLists.txt (Silent stubs section / guest_net_* tests). Production change here is sceNetShowNetstat only. #6285 is sceNetShowIfconfig — rebase debt/CMake hunk if that PR lands first. Depends on: none.

@github-actions

Copy link
Copy Markdown

Progress report (0afa6a6 → b162855)

📈 System libraries: 88.74% (+0.03%, +1 implemented functions)

✅ 1 implemented
Library Name
libSceNet sceNetShowNetstat
⚪ 1 behaviourally empty (constant return or throw)
Library Name
libSceNet sceNetShowNetstat

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 5836 core/libs/prx/libSceNet/CMakeLists.txt
core/libs/prx/libSceNet/Export.cpp
docs/dev/debt/libSceNet.md
PR 5930 core/libs/prx/libSceNet/CMakeLists.txt
core/libs/prx/libSceNet/Export.cpp
PR 6044 core/libs/prx/libSceNet/CMakeLists.txt
PR 6140 core/libs/prx/libSceNet/Export.cpp
PR 6142 core/libs/prx/libSceNet/Export.cpp
PR 6447 core/libs/prx/libSceNet/Export.cpp
docs/dev/debt/libSceNet.md
PR 6494 core/libs/prx/libSceNet/Export.cpp
docs/dev/debt/libSceNet.md
PR 6603 core/libs/prx/libSceNet/Export.cpp
docs/dev/debt/libSceNet.md
PR 6886 core/libs/prx/libSceNet/Export.cpp
docs/dev/debt/libSceNet.md

@mazen320

Copy link
Copy Markdown
Contributor Author

Overlap

Bot flagged docs/dev/debt/libSceNet.md with #5928. This PR is Net sceNetShowNetstat silent stub only. Depends on: none.

@mazen320

Copy link
Copy Markdown
Contributor Author

Silent-stub evidence (re #6274 bar)

CONTRIBUTING allows a silent stub only when it unblocks a title and only affects the UI (or is otherwise safe to ignore).

For sceNetShowNetstat:

  • It is a Show* diagnostic dump (no host netstat output), not Acm/audio or FlipMaster-style runtime control.
  • Debt/title note: PPSA11386 imports it and does not call it during start-up.

Happy to withdraw this too if reviewers want a stricter “must be dialog/UI library” reading.

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 16, 2026
@mazen320

Copy link
Copy Markdown
Contributor Author

Closing. sceNetShowNetstat already returns 0 on main, and guest_sce_net already checks that return. That landed in #4785. Rebasing this branch only adds a second test of the same call.

@mazen320 mazen320 closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build docs needs rebase Conflicts with main, rebase needed prx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant