Repository navigation
Conversation
PPSA11386 imports the unknown-signature export; return 0 with no netstat dump and list it under Silent stubs.
Contributor
Author
11 tasks done
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
Contributor
Author
OverlapBot flagged |
11 tasks done
11 tasks done
Contributor
Author
Silent-stub evidence (re #6274 bar)CONTRIBUTING allows a silent stub only when it unblocks a title and only affects the UI (or is otherwise safe to ignore). For
Happy to withdraw this too if reviewers want a stricter “must be dialog/UI library” reading. |
11 tasks done
Contributor
Author
|
Closing. sceNetShowNetstat already returns 0 on main, and guest_sce_net already checks that return. That landed in #4785. Rebasing this branch only adds a second test of the same call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceNetShowNetstatno longer callsNotImplemented_nid_no_patch. It returns 0 with no netstat dump.PPSA11386 imports it with an unknown signature. Debt moved into Silent stubs. New
guest_net_show_netstatcovers the return.Silent stub evidence (CONTRIBUTING)
A silent stub is allowed only when it unblocks a title and only affects the UI (or is otherwise safe to ignore). Load-stop alone is not enough (see #6274).
Show*diagnostic dump; the stub produces no host netstat output and does not change sockets or routingThis is the same class of exception as an unused import: returning 0 does not skip measured net behaviour on the observed path. If reviewers want a stricter “dialog/UI library only” reading, this PR can be withdrawn.
Tested
Windows 11.
python tools/check_conventions.py --base upstream/mainpassed. Built the original libc, libkernel, libSceNet and test targets from this PR head in a separate CMake harness.ctest --output-on-failure -R ^guest_net_show_netstat$passed on 2026-10-15. This is local targeted validation; upstream full builds remain skipped.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)