Repository navigation
Conversation
MarcZX10
force-pushed
the
codex/amd-gpl-driver-cache-key
branch
2 times, most recently
from
October 15, 2026 10:14
bbd9cda to
da8e370
Compare
This was referenced Oct 15, 2026
Merged
This was referenced Oct 15, 2026
Closed
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
AMD's Windows driver compiles pipelines differently when VK_EXT_graphics_pipeline_library is enabled on the device, but its on-disk cache (%LOCALAPPDATA%\AMD\VkCache) does not key on it. A process in one mode is then served pipelines compiled in the other, and their writes never land (boykopovar#4768, boykopovar#5271). With the library feature off, every module now flips bit 15 of the SPIR-V generator word, which no driver interprets, so the two modes hash to separate cache entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarcZX10
force-pushed
the
codex/amd-gpl-driver-cache-key
branch
from
October 16, 2026 20:35
da8e370 to
1618399
Compare
Contributor
Author
|
Rebased onto current |
11 tasks done
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #4768. AMD's Windows Vulkan driver can reuse a cached pipeline compiled with the opposite
VK_EXT_graphics_pipeline_librarydevice-feature mode. In that case, shader writes may not land. When the feature is disabled, change bit 15 of the SPIR-V generator word before creating each shader module. Vulkan ignores that word, while the driver's on-disk cache hashes the changed module separately. Apply this to recompiled and embedded modules so all AGC shader paths use distinct cache keys.Tested
agc_shader_memory_testsandagc_driver_alpha_to_coverage_testscompile;agc_shader_memory_testspasses (ANYPS5_NO_SHADER_CACHE=1).python3 tools/check_conventions.py --base upstream/main --head HEAD: passed.git diff upstream/main...HEAD --check: passed.Checklist