Repository navigation
fix(shader): qualify SRT memory flags template - #6306
Merged
adriadam10 merged 1 commit intoOct 18, 2026
Merged
Conversation
Contributor
Author
|
I independently applied this exact |
This was referenced Oct 15, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
11 tasks done
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Qualify the dependent
Flags<MemoryFlags>()member-template call in SRT descriptor evaluation. GCC 12 otherwise rejects this expression while compilingSrtDescriptorEvaluation.cpp.Tested
Linux x86-64, GCC 12.2.0, Release: built
agc_shader_memory_tests; ran the test executable and the five CTest casesagc_shader_frontend_pair,agc_shader_frontend_pair_off,agc_shader_layout_pair,agc_shader_layout_pair_off, andagc_shader_memory. All passed. No GPU was used.Checklist
main; no other open PR implements the same change.mdfiles or images added to the repository