Skip to content

fix(shader): qualify SRT memory flags template - #6306

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
MarcZX10:codex/qualify-srt-memory-flags
Oct 18, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
MarcZX10:codex/qualify-srt-memory-flags

Conversation

@MarcZX10

@MarcZX10 MarcZX10 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What

Qualify the dependent Flags<MemoryFlags>() member-template call in SRT descriptor evaluation. GCC 12 otherwise rejects this expression while compiling SrtDescriptorEvaluation.cpp.

Tested

Linux x86-64, GCC 12.2.0, Release: built agc_shader_memory_tests; ran the test executable and the five CTest cases agc_shader_frontend_pair, agc_shader_frontend_pair_off, agc_shader_layout_pair, agc_shader_layout_pair_off, and agc_shader_memory. All passed. No GPU was used.

Checklist

  • Based on current main; no other open PR implements the same change
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw; no paths changed
  • No notes, investigation .md files or images added to the repository
  • New third-party code is a submodule built from source; no third-party code added
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • GPUs tested: n/a; this is a compile and CPU test change
  • AI-assisted: yes

@github-actions github-actions Bot added the shader core/shader label Oct 15, 2026
@MarcZX10

Copy link
Copy Markdown
Contributor Author

I independently applied this exact template qualifier in an isolated worktree to get past GCC 12.2 parsing Flags<MemoryFlags>(). The full agc_driver_image_table_reuse_tests target then built and linked successfully (241 remaining Ninja steps). I could not execute the binary here: AnyPS5 exits at its host CPU guard because this container exposes an Intel Xeon E5-1620 v2 without the required AVX2/BMI features, before Vulkan initialization. The temporary edit and build outputs were removed afterward.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 1341 core/shader/recompiler/Optimization/src/SrtWalker/SrtDescriptorEvaluation.cpp
PR 5609 core/shader/recompiler/Optimization/src/SrtWalker/SrtDescriptorEvaluation.cpp
PR 6539 core/shader/recompiler/Optimization/src/SrtWalker/SrtDescriptorEvaluation.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shader core/shader

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants