Repository navigation
test(ci): reuse Node for build eligibility scenarios - #6583
adriadam10 merged 1 commit into
Conversation
8c6395b to
e192246
Compare
|
I traced the Windows |
|
Rebase handoff — rebased onto current Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release,
To pick it up: Head is |
e192246 to
ab2c6ee
Compare
|
Thanks for rebasing this onto current main and resolving the 90 s timeout overlap. I applied the handoff to the PR branch, preserving the MarcZX100 commit author and using MarcZX100 as committer. The focused suite passes 7/7, conventions pass, and diff check is clean on the rebased head |
|
I propose merging #6484 first, then rebasing #6583. Both edit the harness completion and timeout handling: #6484 adds progress and timeout diagnostics, while #6583 replaces the per-scenario subprocess design. Its rebase can then adapt the useful failure diagnostics to the persistent harness. This order concerns the shared CI test file; the filesystem changes are independent. If that order works for you, please declare AI-assisted: yes (Codex). |
|
Agreed on the ordering. I updated the checklist to |
ab2c6ee to
a56f40b
Compare
What
The
build_eligibilitytests launched a fresh Node process for each scenario. Two Windows relinker CI runs timed out in this test while starting the nested harness: #5978 (two scenarios) and #6184 (one scenario). This PR keeps one Node harness process alive for the test class and sends each independent scenario as a JSON line. The cases and their assertions are unchanged, and each response retains the existing 20-second timeout.Tested
Debian 12, Python 3.11.2, Node 20.19.2:
python3 -m unittest tools.tests.test_build_eligibilitypasses 7/7 in 0.044 s.python3 tools/check_conventions.py --base upstream/mainpasses.git diff --checkpasses.The Windows failures are recorded in #5978 and the #6184 relinker run. I have not run this change on Windows locally; its hosted Windows check will validate the behavior there.
Checklist
main; no other open PR changes this test