Skip to content

Improve perf CI #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Improve perf CI #490

merged 1 commit into from
Jun 24, 2025

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Jun 20, 2025

The PR:

  • Runs cargo bench for master to use it as a more reliable reference. (need to merge .github/scripts/run-benchmarks.sh first)
  • create a .sh file to launch the benchmarks
  • Set alert-threshold to 10%
  • Limit the number of samples to 10 (speed up the CI)

@atuchin-m atuchin-m self-assigned this Jun 20, 2025
@atuchin-m atuchin-m force-pushed the improve-perf-ci branch 3 times, most recently from 45a84f1 to d5ca13d Compare June 20, 2025 16:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 0f62f55 Previous: 1c4e2ac Ratio
rule-match-browserlike/brave-list 2219897574 ns/iter (± 13339832) 2294016871 ns/iter (± 38996419) 0.97
rule-match-first-request/brave-list 985270 ns/iter (± 6285) 1034344 ns/iter (± 9389) 0.95
blocker_new/brave-list 148723692 ns/iter (± 2119812) 168280639 ns/iter (± 977140) 0.88
blocker_new/brave-list-deserialize 60853446 ns/iter (± 832066) 69082647 ns/iter (± 328807) 0.88
memory-usage/brave-list-initial 16225933 ns/iter (± 3) 16225933 ns/iter (± 3) 1
memory-usage/brave-list-initial/max 64817658 ns/iter (± 3) 64817658 ns/iter (± 3) 1
memory-usage/brave-list-initial/alloc-count 1514650 ns/iter (± 3) 1514650 ns/iter (± 3) 1
memory-usage/brave-list-1000-requests 2505592 ns/iter (± 3) 2505576 ns/iter (± 3) 1.00
memory-usage/brave-list-1000-requests/alloc-count 66070 ns/iter (± 3) 66038 ns/iter (± 3) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@atuchin-m atuchin-m marked this pull request as ready for review June 20, 2025 20:28
@atuchin-m atuchin-m requested a review from antonok-edm as a code owner June 20, 2025 20:28
@atuchin-m atuchin-m merged commit 4738d3f into master Jun 24, 2025
9 checks passed
@atuchin-m atuchin-m deleted the improve-perf-ci branch June 24, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants