Skip to content

Improve perf CI #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Improve perf CI #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/scripts/run-benchmarks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/bin/bash

# Performance benchmarking script
# Usage: ./scripts/run-benchmarks.sh

set -e

echo "Running network filter matching benchmark..."
cargo bench --bench bench_matching rule-match-browserlike/brave-list -- --output-format bencher

echo "Running first request matching delay benchmark..."
cargo bench --bench bench_matching rule-match-first-request -- --output-format bencher

echo "Running startup speed benchmark..."
cargo bench --bench bench_rules blocker_new/brave-list -- --output-format bencher

echo "Running memory usage benchmark..."
cargo bench --bench bench_memory memory-usage -- --output-format bencher
18 changes: 5 additions & 13 deletions .github/workflows/perf-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,12 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout
- name: Checkout PR
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Bench network filter matching
run: cargo bench --bench bench_matching rule-match-browserlike/brave-list -- --output-format bencher | tee -a output.txt

- name: Bench first request matching delay
run: cargo bench --bench bench_matching rule-match-first-request -- --output-format bencher | tee -a output.txt

- name: Bench startup speed
run: cargo bench --bench bench_rules blocker_new/brave-list -- --output-format bencher | tee -a output.txt

- name: Bench memory usage
run: cargo bench --bench bench_memory -- --output-format bencher | tee -a output.txt
- name: Run benchmarks
run: |
./.github/scripts/run-benchmarks.sh | tee -a output.txt

- name: Store benchmark result
uses: benchmark-action/github-action-benchmark@d48d326b4ca9ba73ca0cd0d59f108f9e02a381c7 # v1.20.4
Expand All @@ -44,7 +36,7 @@ jobs:
tool: 'cargo'
output-file-path: output.txt
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: '130%' # fails on +30% regression
alert-threshold: '110%' # fails on +10% regression
comment-on-alert: true
fail-on-alert: true
comment-always: true
Expand Down
2 changes: 1 addition & 1 deletion benches/bench_matching.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ fn rule_match_browserlike_comparable(c: &mut Criterion) {
let requests_len = requests.len() as u64;

group.throughput(Throughput::Elements(requests_len));
group.sample_size(20);
group.sample_size(10);

fn requests_parsed(requests: &[TestRequest]) -> Vec<(String, String, String, String, bool)> {
requests
Expand Down