Skip to content

Conversation

mdjastrzebski
Copy link
Member

Summary

Test plan

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.92%. Comparing base (62b5dfd) to head (a8f0ce4).

Files with missing lines Patch % Lines
src/user-event/scroll/pull-to-refresh.ts 82.14% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
- Coverage   89.95%   89.92%   -0.03%     
==========================================
  Files          98      100       +2     
  Lines        5863     5907      +44     
  Branches      942      949       +7     
==========================================
+ Hits         5274     5312      +38     
- Misses        584      589       +5     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

}

const refreshControl = element.props.refreshControl;
if (refreshControl == null || typeof refreshControl.props.onRefresh !== 'function') {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Refresh Control Access Error & Misleading Documentation

Accessing refreshControl.props.onRefresh can lead to a TypeError if refreshControl.props is null or undefined. Separately, the error message for pullToRefresh() is misleading, stating it only works with ScrollView elements when FlatList and SectionList are also supported.

Fix in Cursor Fix in Web

@mdjastrzebski mdjastrzebski mentioned this pull request Sep 18, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant